walklown commented on code in PR #14106:
URL: https://github.com/apache/dubbo/pull/14106#discussion_r1641765580
##########
dubbo-metrics/dubbo-metrics-annotation/pom.xml:
##########
@@ -23,20 +23,18 @@
<version>${revision}</version>
<relativePath>../pom.xml</relativePath>
</parent>
- <artifactId>dubbo-metrics-event</artifactId>
+ <artifactId>dubbo-metrics-annotation</artifactId>
Review Comment:
The new commit separates MetricsServiceExporter to dubbo-metrics-api, and
rename dubbo-metrics-annotation to dubbo-metrics-monitor.
dubbo-metrics-monitor retains some monitor interfaces. These interfaces have
been marked as deprecated and are still relied upon by various packages.
I'm not sure if this is a good idea, do you have any suggestions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
