oxsean commented on code in PR #14702:
URL: https://github.com/apache/dubbo/pull/14702#discussion_r1771420082
##########
dubbo-spring-boot/dubbo-spring-boot-3-autoconfigure/pom.xml:
##########
@@ -68,9 +68,9 @@
</dependency>
<dependency>
- <groupId>jakarta.servlet</groupId>
- <artifactId>jakarta.servlet-api</artifactId>
- <optional>true</optional>
+ <groupId>org.apache.tomcat.embed</groupId>
+ <artifactId>tomcat-embed-core</artifactId>
+ <scope>provided</scope>
Review Comment:
> This change will cause users to have to use Tomcat.
The scope is provided, which doesn't have any actual impact, just adds
special support for Tomcat, as Tomcat already includes the servlet-api, so it
can be replaced directly.
Add a ConditionalOnClass to avoid dependency on tomcat.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
