arvindshmicrosoft commented on a change in pull request #338:
URL: https://github.com/apache/fluo-muchos/pull/338#discussion_r490638080
##########
File path: lib/muchos/ec2.py
##########
@@ -322,8 +323,8 @@ def terminate(self):
if path.isfile(self.config.hosts_path):
os.remove(self.config.hosts_path)
print("Removed hosts file at ", self.config.hosts_path)
- else:
- print("Aborted termination")
+ else:
Review comment:
Thank you @plainolneesh. I reviewed this thoroughly again, and I am
convinced we need to back this out. To help things move along faster and to
avoid any confusion, I have pushed [this
commit](https://github.com/arvindshmicrosoft/fluo-muchos/commit/f0ee40078d672dfd438f92d2bc39d5da44494230)
to my fork. Please take a look and merge if okay. After this, I am pretty much
good to approve the PR. @keith-turner please do take a look, and LMK if you are
okay with resolving this comment?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
