keith-turner commented on code in PR #1122:
URL: https://github.com/apache/fluo/pull/1122#discussion_r1015798556
##########
modules/integration-tests/pom.xml:
##########
@@ -77,6 +77,19 @@
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-client-api</artifactId>
</dependency>
+ <!--LogIT uses log4j V1 APIs to gather log statemtents to veify their
correctness. So here we are loading the log4j V2 api shim for V1. -->
+ <dependency>
+ <groupId>org.apache.logging.log4j</groupId>
+ <artifactId>log4j-1.2-api</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.logging.log4j</groupId>
+ <artifactId>log4j-core</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.logging.log4j</groupId>
+ <artifactId>log4j-slf4j2-impl</artifactId>
+ </dependency>
Review Comment:
Yeah it would be good to figure out if there is a better way to get log
message in a unit test using log4j2. I searched around a bit and didn't find
anything. Seems like this would be a common need.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@fluo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
