keith-turner commented on a change in pull request #883: Fixes #842 Support 
multiple ways for running Fluo applications
URL: https://github.com/apache/incubator-fluo/pull/883#discussion_r128868995
 
 

 ##########
 File path: 
modules/api/src/main/java/org/apache/fluo/api/config/SimpleConfiguration.java
 ##########
 @@ -186,6 +166,30 @@ public String getString(String key, String defaultValue) {
     return internalConfig.getString(key, defaultValue);
   }
 
+  public void load(InputStream in) {
 
 Review comment:
   since tag? javadoc?  need to document if the load merges or clears before 
loading.  Also need to document what the behavior is if multiple loads have the 
same prop, does the last one loaded always win?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to