keith-turner commented on a change in pull request #883: Fixes #842 Support
multiple ways for running Fluo applications
URL: https://github.com/apache/incubator-fluo/pull/883#discussion_r130121989
##########
File path: modules/api/src/main/java/org/apache/fluo/api/client/FluoAdmin.java
##########
@@ -134,6 +132,8 @@ void initialize(InitializationOptions opts) throws
AlreadyInitializedException,
*/
void updateSharedConfig();
+ FluoConfiguration getSharedConfig();
Review comment:
Could have two methods here. One that returns exactly what config was
passed to the factory and another that passes what config is stored in
zookeeper. We could create another issue to support merging one simple config
into another. This would be a good starter issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
