keith-turner commented on a change in pull request #891: Migrate to checkstyle 8.1 rules URL: https://github.com/apache/fluo/pull/891#discussion_r131761990
########## File path: src/main/resources/org/apache/fluo/resources/java-checkstyle.xml ########## @@ -30,6 +28,8 @@ </module> <module name="TreeWalker"> + <module name="SuppressWithNearbyCommentFilter"/> Review comment: > I thought that's basically what my log message said, but I can reword it if it's not clear. Before I looked at the code changes, based on the commit message I was expecting this change to change a pointer to an externally versioned resource. When I looked at the code changes I was not sure what was what, not sure if a better log messages would have helped. I don't care if you change the message, just made that comment about the commit message based on my first impression. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
