[ 
https://issues.apache.org/jira/browse/FREEMARKER-229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17913102#comment-17913102
 ] 

Matteo Franci edited comment on FREEMARKER-229 at 1/14/25 11:25 PM:
--------------------------------------------------------------------

Thanks fo the feedback [~ddekany] 

About single jar : Starting from the last point : I totally agree it is better 
to hava just one compatible jar as you stated (the project I linked is just a 
Proof of concept).

About implementation : As soon as I can spare some time I will try to create a 
pull request (on GitHub mirror  ok?) including your advices for logging and 
multi release jar.

Abount testing : I think I should be possible to setup a GitHub actions for 
testing. On another project I'm using a workflow to build a test project to 
check compliance : 

[https://github.com/fugerit-org/fj-doc/blob/main/.github/workflows/build_fj-doc-native-quarkus_test.yml]

Is this acceptable?

Regards

 


was (Author: fugerit):
Thanks fo the feedback [~ddekany] 

About single jar : Starting from the last point : I totally agree it is better 
to hava just one compatible jar as you stated (the project I linked is just a 
Proof of concept).

About implementation : As soon as I can spare some time I will try to create a 
pull request (on GitHub mirror  ok?) including your advices for logging and 
multi release jar.

Abount testing : I think I should be possible to setup a GitHub actions for 
testing. On another project I'm using a workflow to build a test project which 
test compliance : 

[https://github.com/fugerit-org/fj-doc/blob/main/.github/workflows/build_fj-doc-native-quarkus_test.yml]

Is this acceptable?

Regards

 

> Add GraalVM native support for Apache FreeMarker
> ------------------------------------------------
>
>                 Key: FREEMARKER-229
>                 URL: https://issues.apache.org/jira/browse/FREEMARKER-229
>             Project: Apache Freemarker
>          Issue Type: New Feature
>            Reporter: Matteo Franci
>            Priority: Minor
>
> First of all I want to thank you for the great work on Apache FreeMarker. The 
> team I work with and I have been using on many projects.
> As we are using more and more GraalVM native applications in our team, It 
> would be nice to have some sort of built-in support.
> Currently I only found a community support on [GraalVM reachbility 
> metadata.|https://github.com/oracle/graalvm-reachability-metadata/blob/master/metadata/org.freemarker/freemarker/index.json]
> So I created a github repo we are using to add GraalVM support to projects : 
> [https://github.com/fugerit-org/freemarker-native]
> NOTE: main limitations is that requires java 11+ because of [GraalVM SDK 
> Substitute 
> Annotation|https://www.graalvm.org/sdk/javadoc/com/oracle/svm/core/annotate/Substitute.html].
>  this is needed to fix missing org.apache.log4j.MDC class in  
> [https://github.com/apache/freemarker/blob/v2.3.34/freemarker-core/src/main/java/freemarker/log/_Log4jOverSLF4JTester.java#L35]
> I had a look at the main repository : 
> [https://github.com/apache/freemarker/tree/2.3-gae]
> And maybe it is possible to include all the necessary changes in it, or build 
> a "native support" module, alongside the main distribution.
> What do you think?
> If I can help you anyway I'm here.
> Thanks in advance.
> NOTE: here you can find more details on how GraalVM support has been added 
> [https://github.com/fugerit-org/freemarker-native/blob/main/src/main/docs/native-support/index.adoc]
>  .



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to