[
https://issues.apache.org/jira/browse/FREEMARKER-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16075716#comment-16075716
]
ASF GitHub Bot commented on FREEMARKER-55:
------------------------------------------
GitHub user woonsan opened a pull request:
https://github.com/apache/incubator-freemarker/pull/26
FREEMARKER-55: polishing and cleanups in TaglibFactory builder
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/woonsan/incubator-freemarker
feature/FREEMARKER-55
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-freemarker/pull/26.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #26
----
commit 519680accbb42aaf48eda1e656008249559d0ae8
Author: Woonsan Ko <woon...@apache.org>
Date: 2017-07-05T17:54:01Z
FREEMARKER-55: remove unnecessary exposures and package name change.
commit 3c91ecb65ac12973c05421ec6a265020cfccdc5b
Author: Woonsan Ko <woon...@apache.org>
Date: 2017-07-05T18:11:18Z
FREEMARKER-55: use servlet api 3.0, jsp-api 2.2, jsp-el 2.2 and spring 4.0.x
commit dcbebe9b19e85dff067a46c4394e107916fb7845
Author: Woonsan Ko <woon...@apache.org>
Date: 2017-07-05T20:30:09Z
FREEMARKER-55: moving builder into TaglibFactory
commit c0bb4903c6494c873c97d9a0190de68288e4a1bb
Author: Woonsan Ko <woon...@apache.org>
Date: 2017-07-05T20:37:32Z
FREEMARKER-55: simplify builder constructor
commit 78071707b4ed13e1bcec4dc16fb55ffdf62e12e0
Author: Woonsan Ko <woon...@apache.org>
Date: 2017-07-05T20:45:44Z
FREEMARKER-55: TaglibFactory must be created only by builder.
commit 8621226442bc5bdcdc9b594a688e6f9ce0e80097
Author: Woonsan Ko <woon...@apache.org>
Date: 2017-07-05T21:10:32Z
FREEMARKER-55: removing mutable setters in TaglibFactory
commit 196158b03c18534466d8a0275052515317475474
Author: Woonsan Ko <woon...@apache.org>
Date: 2017-07-05T21:52:05Z
FREEMARKER-55: code cleanup in TaglibFactory, using generics and some
formatting
commit 2a8d76179ba783de5d81e24fa2ec1ec7ad001e39
Author: Woonsan Ko <woon...@apache.org>
Date: 2017-07-05T22:45:50Z
FREEMARKER-55: cleanups (while loop and input streams)
commit e12792ea4e845baf739191ec07b34d60e2653aa9
Author: Woonsan Ko <woon...@apache.org>
Date: 2017-07-05T22:49:32Z
FREEMARKER-55: allow building only once.
commit 14396c83635d2b34612a429312c223afa8836fd4
Author: Woonsan Ko <woon...@apache.org>
Date: 2017-07-06T00:19:21Z
FREEMARKER-55: cleaning up TaglibFactory.Builder
commit 28102af69bca00e3cf29c2dc8a3a6a9d25c56ade
Author: Woonsan Ko <woon...@apache.org>
Date: 2017-07-06T00:49:32Z
FREEMARKER-55: code cleanups using generics
commit 42cfb3261b4f591d822ca91d443f82e12f3e98a5
Author: Woonsan Ko <woon...@apache.org>
Date: 2017-07-06T00:51:00Z
Merge branch '3' into feature/FREEMARKER-55
----
> FM3 freemarker-spring module, Web MVC support
> ---------------------------------------------
>
> Key: FREEMARKER-55
> URL: https://issues.apache.org/jira/browse/FREEMARKER-55
> Project: Apache Freemarker
> Issue Type: Task
> Affects Versions: 3.0.0
> Reporter: Daniel Dekany
>
> Add Spring "Web MVC framework" functionality to freemarker-spring.
> This can be complex task (and the issue possibly has to be subdivided), as it
> involves things like:
> * Some aspects of the FreeMarker 2 integration (developed by the Spring
> developers) are quite confusing ({{FreemarerConfigurer}}, etc.), and we are
> looking into if it needs to be like that.
> * See if we can support {{@EnableWebMvc}} (note that FreeMarker 2 support is
> hard coded into {{ViewResolverRegistry}}, which we can't modify)
> * Creating custom directives/methods to expose Spring features like the
> Spring JSP Tag Library does (but in a way that firs FreeMarker better)
> * Expose JSP custom tag support from the {{freemarker-servlet}} module.
> Depends on: FREEMARKER-54
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
