I wonder if this is really worthwhile. This function is going to be so hard to 
maintain and test. I thought we would completely get rid of this factory 
classes, and just construct the config object right in the command and set the 
values as we validate each group of parameters. We do not want to repeat the 
same number parameters as the command again. It's easy to unit test the command 
class using the parserRule, but it's not easy to unit test this.

[ Full content available at: https://github.com/apache/geode/pull/2998 ]
This message was relayed via gitbox.apache.org for 
notifications@geode.apache.org

Reply via email to