mhansonp commented on a change in pull request #6839:
URL: https://github.com/apache/geode/pull/6839#discussion_r703829525
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/rebalance/model/PartitionedRegionLoadModel.java
##########
@@ -470,21 +475,23 @@ public Move findBestRemove(Bucket bucket) {
Move bestMove = null;
for (Member member : bucket.getMembersHosting()) {
- float newLoad = (member.getTotalLoad() - bucket.getLoad()) /
member.getWeight();
- if (newLoad > mostLoaded && !member.equals(bucket.getPrimary())) {
- Move move = new Move(null, member, bucket);
- if (!this.attemptedBucketRemoves.contains(move)) {
- mostLoaded = newLoad;
- bestMove = move;
+ if (member.canDelete(bucket,
partitionedRegion.getDistributionManager()).willAccept()) {
+ float newLoad = (member.getTotalLoad() - bucket.getLoad()) /
member.getWeight();
+ if (newLoad > mostLoaded && !member.equals(bucket.getPrimary())) {
+ Move move = new Move(null, member, bucket);
+ if (!this.attemptedBucketRemoves.contains(move)) {
+ mostLoaded = newLoad;
+ bestMove = move;
+ }
Review comment:
I am not familiar with that code, and I don't think now is the right
time for that. I am happy to submit a new bug for that. See GEODE-9584
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
