jinmeiliao commented on a change in pull request #6835:
URL: https://github.com/apache/geode/pull/6835#discussion_r707815029
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/CacheClientProxy.java
##########
@@ -345,19 +348,15 @@ protected CacheClientProxy(InternalCache cache,
CacheClientNotifier ccn, Socket
initializeClientAuths();
}
- private void initializeClientAuths() {
- if (AcceptorImpl.isPostAuthzCallbackPresent()) {
- clientUserAuths = ServerConnection.getClientUserAuths(proxyID);
- }
+ void initializeClientAuths() {
+ clientUserAuths = ServerConnection.getClientUserAuths(proxyID);
Review comment:
If I just add a constructor that takes a ClientUserAuth object as the
extra parameter instead of the supplier function, would there be any difference
as far as testability goes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
