albertogpz commented on a change in pull request #7114:
URL: https://github.com/apache/geode/pull/7114#discussion_r750499526
##########
File path:
geode-wan/src/distributedTest/java/org/apache/geode/management/internal/cli/commands/AlterRegionCommandWithRemoteLocator.java
##########
@@ -207,8 +207,34 @@ public void
whenAlteringMultipleRegionWithAlterCommandToAddGatewaySendersThenItS
"alter region --name=SecurityCrossReferences
--gateway-sender-id=serialSender1,serialSender2");
return true;
});
+ }
+ /**
+ * Test execution of alter region command, when adding gw sender to already
initialized region is
+ * not taking too much time.
+ * Verify that execution of command will not be halted, due to
PRShadowRegion not available
+ * immediately in all servers.
+ */
+ @Test
+ public void
alterInitializedRegionWithGwSenderOnManyServersDoesNotTakeTooLong() {
Review comment:
This test case seems to pass in my laptop without the fix. Should more
servers be added?
##########
File path:
geode-wan/src/distributedTest/java/org/apache/geode/management/internal/cli/commands/AlterRegionCommandWithRemoteLocator.java
##########
@@ -207,8 +207,34 @@ public void
whenAlteringMultipleRegionWithAlterCommandToAddGatewaySendersThenItS
"alter region --name=SecurityCrossReferences
--gateway-sender-id=serialSender1,serialSender2");
return true;
});
+ }
+ /**
+ * Test execution of alter region command, when adding gw sender to already
initialized region is
+ * not taking too much time.
+ * Verify that execution of command will not be halted, due to
PRShadowRegion not available
+ * immediately in all servers.
+ */
+ @Test
+ public void
alterInitializedRegionWithGwSenderOnManyServersDoesNotTakeTooLong() {
+ gfsh.executeAndAssertThat("create disk-store --name=data
--max-oplog-size=10 --dir=.")
+ .statusIsSuccess();
- }
+ gfsh.executeAndAssertThat(
+ "create region --name=Positions --type=PARTITION_REDUNDANT_PERSISTENT
--disk-store=data --total-num-buckets=1103")
+ .statusIsSuccess();
+
+ gfsh.executeAndAssertThat(
+ "query --query=\"select key,value from " + SEPARATOR +
"Positions.entries\"")
+ .statusIsSuccess();
+
+ gfsh.executeAndAssertThat(
+ "create gateway-sender --id=parallelPositions
--remote-distributed-system-id=1 --enable-persistence=true
--disk-store-name=data --parallel=true")
+ .statusIsSuccess();
+ GeodeAwaitility.await().until(() -> {
Review comment:
Shouldn't you add an atMost() condition here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
