albertogpz commented on pull request #7083: URL: https://github.com/apache/geode/pull/7083#issuecomment-984299269
> Inlined a few comments. Overall looks like a good direction! Here are some general comments and tips: > > 1. Prefer interfaces over abstract methods. > > 2. Standardize on one library instead of mixing them (such as AssertJ for assertions). > > 3. Is there a better word than "txgrouping" for module name and packages? > > 4. Declare variables and APIs with interfaces rather than implementations. > > 5. Always look for an interface to use instead of an implementation (such as InternalCache instead of GemFireCacheImpl) in both tests and product code. > > 6. Always minimize the scope of anything (class, method, variable, constant). Thanks for your comments. Regarding the name, I do not have one that I really like. Other alternatives could be: txeventsgrouping, grouptxevents, txaware,... If you like any of these or have any other proposal, please, let me know. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
