Kris-10-0 commented on a change in pull request #7219:
URL: https://github.com/apache/geode/pull/7219#discussion_r778493119
##########
File path:
geode-for-redis/src/main/java/org/apache/geode/redis/internal/data/RedisSortedSet.java
##########
@@ -323,18 +339,48 @@ public long zinterstore(RegionProvider regionProvider,
RedisKey key, List<ZKeyWe
}
}
}
+
if (addToSet) {
- memberAdd(member, newScore);
+ OrderedSetEntry entry = interMembers.get(member);
+ if (entry == null) {
+ entry = new OrderedSetEntry(member, newScore);
+ interMembers.put(member, entry);
+ interScores.add(entry);
+ } else if (entry.getScore() != newScore) {
+ interScores.remove(entry);
+ entry.updateScore(newScore);
+ interScores.add(entry);
+ }
}
}
- if (removeFromRegion()) {
- regionProvider.getDataRegion().remove(key);
- } else {
- regionProvider.getLocalDataRegion().put(key, this);
+ return sortedSetOpStoreResult(regionProvider, key, interMembers,
interScores);
+ }
+
+ @VisibleForTesting
+ static long sortedSetOpStoreResult(RegionProvider regionProvider, RedisKey
destinationKey,
+ MemberMap interMembers, ScoreSet interScores) {
+ RedisSortedSet destinationSet =
+ regionProvider.getTypedRedisDataElseRemove(REDIS_SORTED_SET,
destinationKey, false);
Review comment:
getTypedRedisDataElseRemoved() was created in SDIFFSTORE with Darrel to
serialize the data. I copied and pasted the function here so I would be able to
use it until SDIFFSTORE was merged in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
