DonalEvans commented on a change in pull request #7227:
URL: https://github.com/apache/geode/pull/7227#discussion_r778984894
##########
File path:
geode-for-redis/src/integrationTest/java/org/apache/geode/redis/internal/commands/executor/set/AbstractSMoveIntegrationTest.java
##########
@@ -34,16 +33,19 @@
import org.apache.geode.redis.ConcurrentLoopingThreads;
import org.apache.geode.redis.RedisIntegrationTest;
import org.apache.geode.redis.internal.RedisConstants;
-import org.apache.geode.test.awaitility.GeodeAwaitility;
public abstract class AbstractSMoveIntegrationTest implements
RedisIntegrationTest {
Review comment:
No, different slots. Currently all the tests are using keys which have
the same tag, {user1}, which means that they'll all map to the same slot
(that's the purpose of using tags). It would be good to have a test where one
key is `{tag1}key` and the other key is `{tag2}key` so that the slots they map
to are different and we can see the behaviour for that case is correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
