DonalEvans commented on pull request #7257:
URL: https://github.com/apache/geode/pull/7257#issuecomment-1010561019
In addition to the comments I left, this test if added to
`AbstractZInterStoreIntegrationTest` also passes with native Redis but fails
with geode-for-redis:
```
@Test
public void
shouldReturnWrongTypeError_withNonSortedSetKeyAsThirdSourceKeyAndNonExistentSortedSetAsFirstSourceKey()
{
jedis.zadd(KEY2, 1, "value2");
final String STRING_KEY = "{tag1}stringKey";
jedis.set(STRING_KEY, "value");
assertThatThrownBy(() -> jedis.zinterstore(NEW_SET,
"{tag1}nonExistentKey", KEY2,
STRING_KEY)).hasMessageContaining(RedisConstants.ERROR_WRONG_TYPE);
}
```
This can be fixed by changing the for loop in the `zinterstore()` method to
the following:
```
for (ZKeyWeight keyWeight : keyWeights) {
RedisSortedSet set =
regionProvider.getTypedRedisData(REDIS_SORTED_SET,
keyWeight.getKey(), false);
if (set != NULL_REDIS_SORTED_SET) {
sets.add(set);
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
