jdeppe-pivotal commented on a change in pull request #7285:
URL: https://github.com/apache/geode/pull/7285#discussion_r788332620
##########
File path: ci/scripts/repeat-new-tests.sh
##########
@@ -103,5 +103,5 @@ export GRADLE_TASK_OPTIONS="-Prepeat=50
-PfailOnNoMatchingTests=false"
echo "GRADLE_TASK_OPTIONS=${GRADLE_TASK_OPTIONS}"
echo "GRADLE_TASK=${GRADLE_TASK}"
-${SCRIPTDIR}/execute_tests.sh
+#${SCRIPTDIR}/execute_tests.sh
Review comment:
Is this intentional?
##########
File path: ci/scripts/repeat-new-tests.sh
##########
@@ -70,19 +70,19 @@ CHANGED_FILES_ARRAY=( $UNIT_TEST_CHANGES
$INTEGRATION_TEST_CHANGES $DISTRIBUTED_
NUM_CHANGED_FILES=${#CHANGED_FILES_ARRAY[@]}
echo "${NUM_CHANGED_FILES} changed test files"
-for T in ${CHANGED_FILES_ARRAY[@]}; do
+for T in "${CHANGED_FILES_ARRAY[@]}"; do
echo " ${T}"
done
-if [[ "${NUM_CHANGED_FILES}" -eq 0 ]]
+if [[ "${NUM_CHANGED_FILES}" -eq "0" ]]
Review comment:
Shouldn't be necessary since `-eq` acts on arithmetic expressions.
Either way it works though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
