DonalEvans commented on a change in pull request #7319:
URL: https://github.com/apache/geode/pull/7319#discussion_r794100459
##########
File path:
geode-for-redis/src/main/java/org/apache/geode/redis/internal/data/RedisSet.java
##########
@@ -300,7 +283,7 @@ private void srandomDuplicateList(int count, List<byte[]>
result) {
}
}
- private void srandomUniqueListWithSmallCount(int count, List<byte[]> result)
{
+ private void srandomUniqueListAddToResult(int count, List<byte[]> result,
boolean isSPop) {
Review comment:
Ah, true. The behaviour would be correct with SPOP, but as you say,
we're creating a HashSet that we don't need to here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
