kirklund edited a comment on pull request #7299: URL: https://github.com/apache/geode/pull/7299#issuecomment-1027324608
This new unit test failure seems to indicate that something in unit tests set a process-wide filter which I've been very careful to avoid. The test that fails is asserting that the process-wide filter is null which then fails because toString is not implemented on the JDK's filter that gets returned. I think it would be safest to change the reflective API wrapper to return boolean that either there is a filter or it's null. I could also store a stack trace that captures whatever sets the filter so I can easily find the code path that sets it. Then if no stack trace is stored, we could also detect when the filter has been set outside Geode's internal filter API which might even be useful outside of precheckin tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
