pivotal-jbarrett commented on a change in pull request #917:
URL: https://github.com/apache/geode-native/pull/917#discussion_r803887440
##########
File path: CMakeLists.txt
##########
@@ -61,6 +61,7 @@ set(PRODUCT_BUILDDATE "1970-01-01" CACHE STRING "Product
build date")
set(PRODUCT_SOURCE_REVISION "0000000000000000000000000000000000000000" CACHE
STRING "Product source SHA")
set(PRODUCT_SOURCE_REPOSITORY "<unspecified>" CACHE STRING "Product source
branch")
set(PRODUCT_BITS "${BUILD_BITS}bit")
+set(GEODE_AUTHEXPIREDEXCEPTION_VERSION "1.15.0-build.546" CACHE STRING "First
build containing AuthenticationExpiredException")
Review comment:
Ok, fair enough, but why the specific build number. When building
locally on your machine, since Apache doesn't do binary releases, that build
number is almost always 0. Just detect "1.15.0". We don't need to handle
building sources between GAs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
