dschneider-pivotal commented on a change in pull request #7354:
URL: https://github.com/apache/geode/pull/7354#discussion_r804028975
##########
File path:
geode-for-redis/src/main/java/org/apache/geode/redis/internal/commands/executor/server/CommandCommandExecutor.java
##########
@@ -77,6 +77,10 @@ private RedisResponse
executeNoSubcommand(ExecutionHandlerContext context) {
oneCommand.add(type.lastKey());
oneCommand.add(type.step());
+ List<String> categories = new ArrayList<>();
+ categories.add("@" + type.category().name().toLowerCase());
Review comment:
could you use Collections.singletonList here?
##########
File path:
geode-for-redis/src/main/java/org/apache/geode/redis/internal/commands/executor/server/CommandCommandExecutor.java
##########
@@ -39,7 +39,7 @@
* COMMAND refers to the redis command being implemented.
Review comment:
this javadoc needs updating since "COMMAND" is no longer part of the
class name
##########
File path:
geode-for-redis/src/main/java/org/apache/geode/redis/internal/commands/RedisCommandType.java
##########
@@ -394,22 +475,28 @@
private final Parameter parameterRequirements;
private final Parameter deferredParameterRequirements;
private final RedisCommandSupportLevel supportLevel;
+ private final Category category;
- RedisCommandType(CommandExecutor commandExecutor, RedisCommandSupportLevel
supportLevel) {
- this(commandExecutor, supportLevel, new Parameter().custom(c -> {
+ RedisCommandType(CommandExecutor commandExecutor, Category category,
+ RedisCommandSupportLevel supportLevel) {
+ this(commandExecutor, category, supportLevel, new Parameter().custom(c -> {
Review comment:
do we need to call "custom" to add a noop Consumer lamda? It seems like
`new Parameter()` is all we need.
##########
File path:
geode-for-redis/src/main/java/org/apache/geode/redis/internal/commands/RedisCommandType.java
##########
@@ -394,22 +475,28 @@
private final Parameter parameterRequirements;
private final Parameter deferredParameterRequirements;
private final RedisCommandSupportLevel supportLevel;
+ private final Category category;
- RedisCommandType(CommandExecutor commandExecutor, RedisCommandSupportLevel
supportLevel) {
- this(commandExecutor, supportLevel, new Parameter().custom(c -> {
+ RedisCommandType(CommandExecutor commandExecutor, Category category,
+ RedisCommandSupportLevel supportLevel) {
+ this(commandExecutor, category, supportLevel, new Parameter().custom(c -> {
}));
}
- RedisCommandType(CommandExecutor commandExecutor, RedisCommandSupportLevel
supportLevel,
+ RedisCommandType(CommandExecutor commandExecutor, Category category,
+ RedisCommandSupportLevel supportLevel,
Parameter parameterRequirements) {
- this(commandExecutor, supportLevel, parameterRequirements, new
Parameter().custom(c -> {
- }));
+ this(commandExecutor, category, supportLevel, parameterRequirements,
+ new Parameter().custom(c -> {
Review comment:
Once again `new Parameter()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
