ringles commented on a change in pull request #7362:
URL: https://github.com/apache/geode/pull/7362#discussion_r810139546
##########
File path:
geode-for-redis/src/distributedTest/java/org/apache/geode/redis/OutOfMemoryDUnitTest.java
##########
@@ -181,7 +182,7 @@ public void
shouldReturnOOMError_forWriteOperations_whenThresholdReached() {
await()
.untilAsserted(() -> assertThatThrownBy(() -> jedis.set(server1Tag +
"oneMoreKey", "value"))
- .hasMessageContaining("OOM"));
+ .hasMessage("OOM " + ERROR_OOM_COMMAND_NOT_ALLOWED));
Review comment:
Does it make sense to pull these strings like "OOM", "ERR", "WRONGTYPE",
etc. into constants? They're unlikely to change, of course, but they are
repeated in multiple files and are part of the actual output.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
