albertogpz commented on a change in pull request #7330:
URL: https://github.com/apache/geode/pull/7330#discussion_r812174465
##########
File path:
geode-wan/src/distributedTest/java/org/apache/geode/cache/wan/internal/cli/commands/WanCopyRegionCommandDUnitTest.java
##########
@@ -1460,11 +1460,15 @@ public void createServersAndRegions(int locatorPort,
List<VM> servers,
}
private void waitForWanCopyRegionCommandToStart(boolean useParallel, boolean
usePartitionedRegion,
- List<VM> servers) {
+ List<VM> servers) throws InterruptedException {
+ // Wait for the command execution to be registered in the service
final int executionsExpected = useParallel && usePartitionedRegion ?
servers.size() : 1;
await().untilAsserted(
() -> assertThat(getNumberOfCurrentExecutionsInServers(servers))
.isEqualTo(executionsExpected));
+ // Wait some extra milliseconds to allow for the command to actually start
to
+ // avoid flakyness in the tests.
+ Thread.sleep(100);
Review comment:
> @albertogpz I have not considered working on any of them at the
moment. So feel free to pick up any of them. If you feel you have gotten stuck
or need to chat to anyone about this, please feel free to reach out to me
directly.
>
> [GEODE-10071](https://issues.apache.org/jira/browse/GEODE-10071) and
[GEODE-10068](https://issues.apache.org/jira/browse/GEODE-10068) should be
reasonably simple and to apply
>
> [GEODE-10067](https://issues.apache.org/jira/browse/GEODE-10067) and
[GEODE-10069](https://issues.apache.org/jira/browse/GEODE-10069) would be good
tasks to complete to improve overall simplicity and performance of the current
implementation
>
> [GEODE-10070](https://issues.apache.org/jira/browse/GEODE-10070) is a task
that we need to carefully consider how it is implemented. Please feel free to
reach out to the "experts" on this via the dev-list. Completing this task will
be a huge step in the right direction when it comes to SoC and modularity
@kohlmu-pivotal I will try to find some time to work on some of these items.
I consider [GEODE-10067](https://issues.apache.org/jira/browse/GEODE-10067)
and [GEODE-10069](https://issues.apache.org/jira/browse/GEODE-10069) the most
important ones.
I was thinking that maybe the first one could be solved by the proposal on
the second one, i.e., calling `onRegion()` from one of the members so that when
the function is executed in the corresponding member it could iterate over the
keys in the filter and copy the entries by getting them without deserializing
them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
