jinmeiliao commented on a change in pull request #7348: URL: https://github.com/apache/geode/pull/7348#discussion_r813107678
########## File path: geode-assembly/src/distributedTest/java/org/apache/geode/management/internal/rest/DeploymentManagementClassloaderIsolatedDUnitTest.java ########## @@ -0,0 +1,168 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license + * agreements. See the NOTICE file distributed with this work for additional information regarding + * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. You may obtain a + * copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software distributed under the License + * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express + * or implied. See the License for the specific language governing permissions and limitations under + * the License. + */ + +package org.apache.geode.management.internal.rest; + +import static org.apache.geode.test.junit.assertions.ClusterManagementGetResultAssert.assertManagementGetResult; +import static org.apache.geode.test.junit.assertions.ClusterManagementListResultAssert.assertManagementListResult; +import static org.assertj.core.api.Assertions.assertThat; +import static org.junit.Assume.assumeTrue; + +import java.io.File; +import java.util.List; + +import org.apache.commons.io.FilenameUtils; +import org.junit.BeforeClass; +import org.junit.ClassRule; +import org.junit.Test; +import org.junit.rules.TemporaryFolder; + +import org.apache.geode.distributed.internal.DistributionConfig; +import org.apache.geode.examples.SimpleSecurityManager; +import org.apache.geode.management.api.ClusterManagementGetResult; +import org.apache.geode.management.api.ClusterManagementListResult; +import org.apache.geode.management.api.ClusterManagementService; +import org.apache.geode.management.cluster.client.ClusterManagementServiceBuilder; +import org.apache.geode.management.configuration.Deployment; +import org.apache.geode.management.runtime.DeploymentInfo; +import org.apache.geode.test.compiler.JarBuilder; +import org.apache.geode.test.dunit.rules.ClusterStartupRule; +import org.apache.geode.test.dunit.rules.MemberVM; +import org.apache.geode.test.junit.assertions.ClusterManagementGetResultAssert; +import org.apache.geode.test.junit.assertions.ClusterManagementListResultAssert; + +/** + * This test is only run when we are running with classloader isolation. + * + * @see DeploymentManagementDUnitTest + */ +public class DeploymentManagementClassloaderIsolatedDUnitTest { + @ClassRule + public static ClusterStartupRule cluster = new ClusterStartupRule(); + + private static ClusterManagementService client; + + @ClassRule + public static TemporaryFolder stagingTempDir = new TemporaryFolder(); + + @BeforeClass + public static void beforeClass() throws Exception { + // ignore if classloader isolation is disabled + assumeTrue(Boolean.parseBoolean(System.getProperty("classloader.isolated"))); Review comment: lower case and upper case supported? What's the difference between this test and `DeployToMultiGroupDUnitTest.java`? ########## File path: geode-assembly/src/distributedTest/java/org/apache/geode/management/internal/rest/DeployToMultiGroupDUnitTest.java ########## @@ -58,6 +59,7 @@ @BeforeClass public static void beforeClass() throws Exception { // prepare the jars to be deployed + assumeThat(System.getenv("CLASSLOADER_ISOLATED")).isEqualTo("false"); Review comment: Is this env variable set by the pipeline? ########## File path: geode-web/src/distributedTest/java/org/apache/geode/management/internal/cli/commands/AlterRuntimeCommandDistributedTest.java ########## @@ -125,1231 +118,1236 @@ public void testAlterRuntimeConfig(boolean connectOverHttp) throws Exception { .containsOutput("Could not set \"log-disk-space-limit\" to \"2000000000\""); } - @Test - @Parameters({"true", "false"}) - public void alterLogDiskSpaceLimitWithFileSizeLimitNotSet_OK(boolean connectOverHttp) - throws Exception { - Properties props = new Properties(); - props.setProperty(LOG_LEVEL, "error"); - - MemberVM locator = startupRule.startLocatorVM(0, MemberStarterRule::withHttpService); - MemberVM server1 = startupRule.startServerVM(1, props, locator.getPort()); - MemberVM server2 = startupRule.startServerVM(2, props, locator.getPort()); - - if (connectOverHttp) { - gfsh.connectAndVerify(locator.getHttpPort(), GfshCommandRule.PortType.http); - } else { - gfsh.connectAndVerify(locator.getJmxPort(), GfshCommandRule.PortType.jmxManager); - } - - CommandStringBuilder setLogDiskSpaceLimit = new CommandStringBuilder(ALTER_RUNTIME_CONFIG) - .addOption(ALTER_RUNTIME_CONFIG__LOG__DISK__SPACE__LIMIT, "10"); - - gfsh.executeAndAssertThat(setLogDiskSpaceLimit.toString()) - .statusIsSuccess(); - - for (MemberVM server : new MemberVM[] {server1, server2}) { - server.invoke(() -> { - InternalCache cache = ClusterStartupRule.getCache(); - DistributionConfig config = cache.getInternalDistributedSystem().getConfig(); - - assertThat(config.getLogFileSizeLimit()) - .isEqualTo(0); - assertThat(config.getArchiveDiskSpaceLimit()) - .isEqualTo(0); - assertThat(config.getStatisticSampleRate()) - .isEqualTo(1000); - assertThat(config.getStatisticArchiveFile().getName()) - .isEqualTo(""); - assertThat(config.getStatisticSamplingEnabled()) - .isTrue(); - assertThat(config.getLogDiskSpaceLimit()) - .isEqualTo(10); - }); - } - } - - @Test - @Parameters({"true", "false"}) - public void alterLogDiskSpaceLimitWithFileSizeLimitSet_OK(boolean connectOverHttp) - throws Exception { - Properties props = new Properties(); - props.setProperty(LOG_LEVEL, "error"); - - MemberVM locator = startupRule.startLocatorVM(0, MemberStarterRule::withHttpService); - MemberVM server1 = startupRule.startServerVM(1, props, locator.getPort()); - MemberVM server2 = startupRule.startServerVM(2, props, locator.getPort()); - - if (connectOverHttp) { - gfsh.connectAndVerify(locator.getHttpPort(), GfshCommandRule.PortType.http); - } else { - gfsh.connectAndVerify(locator.getJmxPort(), GfshCommandRule.PortType.jmxManager); - } - - CommandStringBuilder setFileSizeLimit = new CommandStringBuilder(ALTER_RUNTIME_CONFIG) - .addOption(ALTER_RUNTIME_CONFIG__LOG__FILE__SIZE__LIMIT, "50"); - - gfsh.executeAndAssertThat(setFileSizeLimit.toString()) - .statusIsSuccess(); - - server2.invoke(() -> { - InternalCache cache = ClusterStartupRule.getCache(); - DistributionConfig config = cache.getInternalDistributedSystem().getConfig(); - - assertThat(config.getLogFileSizeLimit()) - .isEqualTo(50); - assertThat(config.getLogDiskSpaceLimit()) - .isEqualTo(0); - }); - - CommandStringBuilder setDiskSpaceLimit = new CommandStringBuilder(ALTER_RUNTIME_CONFIG) - .addOption(ALTER_RUNTIME_CONFIG__LOG__DISK__SPACE__LIMIT, "10"); - - gfsh.executeAndAssertThat(setDiskSpaceLimit.toString()) - .statusIsSuccess(); - - for (MemberVM server : new MemberVM[] {server1, server2}) { - server.invoke(() -> { - InternalCache cache = ClusterStartupRule.getCache(); - DistributionConfig config = cache.getInternalDistributedSystem().getConfig(); - - assertThat(config.getLogFileSizeLimit()) - .isEqualTo(50); - assertThat(config.getLogDiskSpaceLimit()) - .isEqualTo(10); - assertThat(config.getArchiveDiskSpaceLimit()) - .isEqualTo(0); - assertThat(config.getStatisticSampleRate()) - .isEqualTo(1000); - assertThat(config.getStatisticArchiveFile().getName()) - .isEqualTo(""); - assertThat(config.getStatisticSamplingEnabled()) - .isTrue(); - }); - } - } - - @Test - @Parameters({"true", "false"}) - public void alterLogDiskSpaceLimitOnMember_OK(boolean connectOverHttp) throws Exception { - Properties props = new Properties(); - props.setProperty(LOG_LEVEL, "error"); - - MemberVM locator = startupRule.startLocatorVM(0, MemberStarterRule::withHttpService); - MemberVM server1 = startupRule.startServerVM(1, props, locator.getPort()); - MemberVM server2 = startupRule.startServerVM(2, props, locator.getPort()); - - if (connectOverHttp) { - gfsh.connectAndVerify(locator.getHttpPort(), GfshCommandRule.PortType.http); - } else { - gfsh.connectAndVerify(locator.getJmxPort(), GfshCommandRule.PortType.jmxManager); - } - - CommandStringBuilder setLogDiskSpaceLimit = new CommandStringBuilder(ALTER_RUNTIME_CONFIG) - .addOption(MEMBER, server1.getName()) - .addOption(ALTER_RUNTIME_CONFIG__LOG__DISK__SPACE__LIMIT, "10"); - - gfsh.executeAndAssertThat(setLogDiskSpaceLimit.toString()) - .statusIsSuccess(); - - for (MemberVM server : new MemberVM[] {server1, server2}) { - int expectedLimit = server == server1 ? 10 : 0; - - server.invoke(() -> { - InternalCache cache = ClusterStartupRule.getCache(); - DistributionConfig config = cache.getInternalDistributedSystem().getConfig(); - - assertThat(config.getLogFileSizeLimit()) - .isEqualTo(0); - assertThat(config.getLogDiskSpaceLimit()) - .isEqualTo(expectedLimit); - assertThat(config.getArchiveDiskSpaceLimit()) - .isEqualTo(0); - assertThat(config.getStatisticSampleRate()) - .isEqualTo(1000); - assertThat(config.getStatisticArchiveFile().getName()) - .isEqualTo(""); - assertThat(config.getStatisticSamplingEnabled()) - .isTrue(); - }); - } - } - - @Test - @Parameters({"true", "false"}) - public void alterLogDiskSpaceLimitOnGroup_OK(boolean connectOverHttp) throws Exception { - Properties props = new Properties(); - props.setProperty(LOG_LEVEL, "error"); - - MemberVM locator = startupRule.startLocatorVM(0, MemberStarterRule::withHttpService); - MemberVM server1 = startupRule.startServerVM(1, props, locator.getPort()); - - props.setProperty(GROUPS, "G1"); - MemberVM server2 = startupRule.startServerVM(2, props, locator.getPort()); - - if (connectOverHttp) { - gfsh.connectAndVerify(locator.getHttpPort(), GfshCommandRule.PortType.http); - } else { - gfsh.connectAndVerify(locator.getJmxPort(), GfshCommandRule.PortType.jmxManager); - } - - String testGroup = "G1"; - int testLimit = 10; - - CommandStringBuilder setLogDiskSpaceLimit = new CommandStringBuilder(ALTER_RUNTIME_CONFIG) - .addOption(CliStrings.GROUPS, testGroup) - .addOption(ALTER_RUNTIME_CONFIG__LOG__DISK__SPACE__LIMIT, valueOf(testLimit)); - - gfsh.executeAndAssertThat(setLogDiskSpaceLimit.toString()) - .statusIsSuccess(); - - for (MemberVM server : new MemberVM[] {server1, server2}) { - int expectedLimit = server == server2 ? testLimit : 0; - String expectedGroup = server == server2 ? testGroup : ""; - - server.invoke(() -> { - InternalCache cache = ClusterStartupRule.getCache(); - DistributionConfig config = cache.getInternalDistributedSystem().getConfig(); - - assertThat(config.getGroups()) - .isEqualTo(expectedGroup); - assertThat(config.getLogFileSizeLimit()) - .isEqualTo(0); - assertThat(config.getLogDiskSpaceLimit()) - .isEqualTo(expectedLimit); - assertThat(config.getArchiveDiskSpaceLimit()) - .isEqualTo(0); - assertThat(config.getStatisticSampleRate()) - .isEqualTo(1000); - assertThat(config.getStatisticArchiveFile().getName()) - .isEqualTo(""); - assertThat(config.getStatisticSamplingEnabled()) - .isTrue(); - }); - } - } - - @Test - @Parameters({"true", "false"}) - public void alterLogFileSizeLimit_changesConfigOnAllServers(boolean connectOverHttp) - throws Exception { - - MemberVM locator = startupRule.startLocatorVM(0, MemberStarterRule::withHttpService); - MemberVM server1 = startupRule.startServerVM(1, locator.getPort()); - MemberVM server2 = startupRule.startServerVM(2, locator.getPort()); - - if (connectOverHttp) { - gfsh.connectAndVerify(locator.getHttpPort(), GfshCommandRule.PortType.http); - } else { - gfsh.connectAndVerify(locator.getJmxPort(), GfshCommandRule.PortType.jmxManager); - } - - CommandStringBuilder setLogFileSizeLimit = new CommandStringBuilder(ALTER_RUNTIME_CONFIG) - .addOption(ALTER_RUNTIME_CONFIG__LOG__FILE__SIZE__LIMIT, "11"); - - gfsh.executeAndAssertThat(setLogFileSizeLimit.toString()) - .statusIsSuccess(); - - for (MemberVM server : new MemberVM[] {server1, server2}) { - server.invoke(() -> { - InternalCache cache = ClusterStartupRule.getCache(); - DistributionConfig config = cache.getInternalDistributedSystem().getConfig(); - - assertThat(config.getLogFileSizeLimit()) - .isEqualTo(11); - assertThat(config.getArchiveDiskSpaceLimit()) - .isEqualTo(0); - assertThat(config.getStatisticSampleRate()) - .isEqualTo(1000); - assertThat(config.getStatisticArchiveFile().getName()) - .isEqualTo(""); - assertThat(config.getStatisticSamplingEnabled()) - .isTrue(); - assertThat(config.getLogDiskSpaceLimit()) - .isEqualTo(0); - }); - } - } - - @Test - @Parameters({"true", "false"}) - public void alterLogFileSizeLimitNegative_errorCanNotSet(boolean connectOverHttp) - throws Exception { - - MemberVM locator = startupRule.startLocatorVM(0, MemberStarterRule::withHttpService); - MemberVM server1 = startupRule.startServerVM(1, locator.getPort()); - MemberVM server2 = startupRule.startServerVM(2, locator.getPort()); - - ignoreIllegalArgumentException("Could not set \"log-file-size-limit\""); - if (connectOverHttp) { - gfsh.connectAndVerify(locator.getHttpPort(), GfshCommandRule.PortType.http); - } else { - gfsh.connectAndVerify(locator.getJmxPort(), GfshCommandRule.PortType.jmxManager); - } - - CommandStringBuilder setLogFileSizeLimit = new CommandStringBuilder(ALTER_RUNTIME_CONFIG) - .addOption(ALTER_RUNTIME_CONFIG__LOG__FILE__SIZE__LIMIT, "-1"); - - gfsh.executeAndAssertThat(setLogFileSizeLimit.toString()) - .statusIsError() - .containsOutput("Could not set \"log-file-size-limit\" to \"-1\""); - - verifyDefaultConfig(new MemberVM[] {server1, server2}); - } - - @Test - @Parameters({"true", "false"}) - public void alterLogFileSizeLimitTooBig_errorCanNotSet(boolean connectOverHttp) - throws Exception { - - MemberVM locator = startupRule.startLocatorVM(0, MemberStarterRule::withHttpService); - MemberVM server1 = startupRule.startServerVM(1, locator.getPort()); - - Properties props = new Properties(); - props.setProperty(GROUPS, "G1"); - MemberVM server2 = startupRule.startServerVM(2, props, locator.getPort()); - - ignoreIllegalArgumentException("Could not set \"log-file-size-limit\""); - if (connectOverHttp) { - gfsh.connectAndVerify(locator.getHttpPort(), GfshCommandRule.PortType.http); - } else { - gfsh.connectAndVerify(locator.getJmxPort(), GfshCommandRule.PortType.jmxManager); - } - - CommandStringBuilder setLogFileSizeLimit = new CommandStringBuilder(ALTER_RUNTIME_CONFIG) - .addOption(ALTER_RUNTIME_CONFIG__LOG__FILE__SIZE__LIMIT, "1000001"); - - CommandStringBuilder withGroup = new CommandStringBuilder(setLogFileSizeLimit.toString()) - .addOption(GROUP, "G1"); - - gfsh.executeAndAssertThat(setLogFileSizeLimit.toString()) - .statusIsError() - .containsOutput("Could not set \"log-file-size-limit\" to \"1000001\""); - - setLogFileSizeLimit.addOption(MEMBER, server2.getName()); - - gfsh.executeAndAssertThat(setLogFileSizeLimit.toString()) - .statusIsError() - .containsOutput("Could not set \"log-file-size-limit\" to \"1000001\""); - - gfsh.executeAndAssertThat(withGroup.toString()) - .statusIsError() - .containsOutput("Could not set \"log-file-size-limit\" to \"1000001\""); - - verifyDefaultConfig(new MemberVM[] {server1, server2}); - } - - @Test - @Parameters({"true", "false"}) - public void alterStatArchiveFile_updatesAllServerConfigs(boolean connectOverHttp) - throws Exception { - Properties props = new Properties(); - props.setProperty(LOG_LEVEL, "error"); - - MemberVM locator = startupRule.startLocatorVM(0, MemberStarterRule::withHttpService); - MemberVM server1 = startupRule.startServerVM(1, props, locator.getPort()); - MemberVM server2 = startupRule.startServerVM(2, props, locator.getPort()); - - if (connectOverHttp) { - gfsh.connectAndVerify(locator.getHttpPort(), GfshCommandRule.PortType.http); - } else { - gfsh.connectAndVerify(locator.getJmxPort(), GfshCommandRule.PortType.jmxManager); - } - - String testName = "statisticsArchive"; - - CommandStringBuilder setStatisticArchiveFile = new CommandStringBuilder(ALTER_RUNTIME_CONFIG) - .addOption(ALTER_RUNTIME_CONFIG__STATISTIC__ARCHIVE__FILE, testName); - - gfsh.executeAndAssertThat(setStatisticArchiveFile.toString()) - .statusIsSuccess(); - - for (MemberVM server : new MemberVM[] {server1, server2}) { - server.invoke(() -> { - InternalCache cache = ClusterStartupRule.getCache(); - DistributionConfig config = cache.getInternalDistributedSystem().getConfig(); - - assertThat(config.getLogFileSizeLimit()) - .isEqualTo(0); - assertThat(config.getArchiveDiskSpaceLimit()) - .isEqualTo(0); - assertThat(config.getStatisticSampleRate()) - .isEqualTo(1000); - assertThat(config.getStatisticArchiveFile().getName()) - .isEqualTo(testName); - assertThat(config.getStatisticSamplingEnabled()) - .isTrue(); - assertThat(config.getLogDiskSpaceLimit()) - .isEqualTo(0); - }); - } - } - - @Test - @Parameters({"true", "false"}) - public void alterStatArchiveFileWithMember_updatesSelectedServerConfigs(boolean connectOverHttp) - throws Exception { - Properties props = new Properties(); - props.setProperty(LOG_LEVEL, "error"); - - MemberVM locator = startupRule.startLocatorVM(0, MemberStarterRule::withHttpService); - MemberVM server1 = startupRule.startServerVM(1, props, locator.getPort()); - MemberVM server2 = startupRule.startServerVM(2, props, locator.getPort()); - - if (connectOverHttp) { - gfsh.connectAndVerify(locator.getHttpPort(), GfshCommandRule.PortType.http); - } else { - gfsh.connectAndVerify(locator.getJmxPort(), GfshCommandRule.PortType.jmxManager); - } - - String testName = "statisticsArchive"; - - CommandStringBuilder setStatisticArchiveFile = new CommandStringBuilder(ALTER_RUNTIME_CONFIG) - .addOption(MEMBER, server1.getName()) - .addOption(ALTER_RUNTIME_CONFIG__STATISTIC__ARCHIVE__FILE, testName); - - gfsh.executeAndAssertThat(setStatisticArchiveFile.toString()) - .statusIsSuccess(); - - for (MemberVM server : new MemberVM[] {server1, server2}) { - String expectedName = server == server1 ? testName : ""; - - server.invoke(() -> { - InternalCache cache = ClusterStartupRule.getCache(); - DistributionConfig config = cache.getInternalDistributedSystem().getConfig(); - - assertThat(config.getLogFileSizeLimit()) - .isEqualTo(0); - assertThat(config.getArchiveDiskSpaceLimit()) - .isEqualTo(0); - assertThat(config.getStatisticSampleRate()) - .isEqualTo(1000); - assertThat(config.getStatisticArchiveFile().getName()) - .isEqualTo(expectedName); - assertThat(config.getStatisticSamplingEnabled()) - .isTrue(); - assertThat(config.getLogDiskSpaceLimit()) - .isEqualTo(0); - }); - } - } - - @Test - @Parameters({"true", "false"}) - public void alterStatArchiveFileWithGroup_updatesSelectedServerConfigs(boolean connectOverHttp) - throws Exception { - Properties props = new Properties(); - props.setProperty(LOG_LEVEL, "error"); - - MemberVM locator = startupRule.startLocatorVM(0, MemberStarterRule::withHttpService); - MemberVM server1 = startupRule.startServerVM(1, props, locator.getPort()); - - props.setProperty(GROUPS, "G1"); - MemberVM server2 = startupRule.startServerVM(2, props, locator.getPort()); - - if (connectOverHttp) { - gfsh.connectAndVerify(locator.getHttpPort(), GfshCommandRule.PortType.http); - } else { - gfsh.connectAndVerify(locator.getJmxPort(), GfshCommandRule.PortType.jmxManager); - } - - String testName = "statisticsArchive"; - - CommandStringBuilder setStatisticArchiveFile = new CommandStringBuilder(ALTER_RUNTIME_CONFIG) - .addOption(GROUP, "G1") - .addOption(ALTER_RUNTIME_CONFIG__STATISTIC__ARCHIVE__FILE, testName); - - gfsh.executeAndAssertThat(setStatisticArchiveFile.toString()) - .statusIsSuccess(); - - for (MemberVM server : new MemberVM[] {server1, server2}) { - String expectedName = server == server2 ? testName : ""; - - server.invoke(() -> { - InternalCache cache = ClusterStartupRule.getCache(); - DistributionConfig config = cache.getInternalDistributedSystem().getConfig(); - - assertThat(config.getLogFileSizeLimit()) - .isEqualTo(0); - assertThat(config.getArchiveDiskSpaceLimit()) - .isEqualTo(0); - assertThat(config.getStatisticSampleRate()) - .isEqualTo(1000); - assertThat(config.getStatisticArchiveFile().getName()) - .isEqualTo(expectedName); - assertThat(config.getStatisticSamplingEnabled()) - .isTrue(); - assertThat(config.getLogDiskSpaceLimit()) - .isEqualTo(0); - }); - } - } - - @Test - @Parameters({"true", "false"}) - public void alterStatSampleRate_updatesAllServerConfigs(boolean connectOverHttp) - throws Exception { - Properties props = new Properties(); - props.setProperty(LOG_LEVEL, "error"); - - MemberVM locator = startupRule.startLocatorVM(0, MemberStarterRule::withHttpService); - MemberVM server1 = startupRule.startServerVM(1, props, locator.getPort()); - MemberVM server2 = startupRule.startServerVM(2, props, locator.getPort()); - - if (connectOverHttp) { - gfsh.connectAndVerify(locator.getHttpPort(), GfshCommandRule.PortType.http); - } else { - gfsh.connectAndVerify(locator.getJmxPort(), GfshCommandRule.PortType.jmxManager); - } - - CommandStringBuilder setStatisticSampleRate = new CommandStringBuilder(ALTER_RUNTIME_CONFIG) - .addOption(ALTER_RUNTIME_CONFIG__STATISTIC__SAMPLE__RATE, "2000"); - - gfsh.executeAndAssertThat(setStatisticSampleRate.toString()) - .statusIsSuccess(); - - for (MemberVM server : new MemberVM[] {server1, server2}) { - server.invoke(() -> { - InternalCache cache = ClusterStartupRule.getCache(); - DistributionConfig config = cache.getInternalDistributedSystem().getConfig(); - - assertThat(config.getLogFileSizeLimit()) - .isEqualTo(0); - assertThat(config.getArchiveDiskSpaceLimit()) - .isEqualTo(0); - assertThat(config.getStatisticSampleRate()) - .isEqualTo(2000); - assertThat(config.getStatisticArchiveFile().getName()) - .isEqualTo(""); - assertThat(config.getStatisticSamplingEnabled()) - .isTrue(); - assertThat(config.getLogDiskSpaceLimit()) - .isEqualTo(0); - }); - } - } - - @Test - @Parameters({"true", "false"}) - public void alterStatSampleRateWithMember_updatesSelectedServerConfigs(boolean connectOverHttp) - throws Exception { - Properties props = new Properties(); - props.setProperty(LOG_LEVEL, "error"); - - MemberVM locator = startupRule.startLocatorVM(0, MemberStarterRule::withHttpService); - MemberVM server1 = startupRule.startServerVM(1, props, locator.getPort()); - MemberVM server2 = startupRule.startServerVM(2, props, locator.getPort()); - - if (connectOverHttp) { - gfsh.connectAndVerify(locator.getHttpPort(), GfshCommandRule.PortType.http); - } else { - gfsh.connectAndVerify(locator.getJmxPort(), GfshCommandRule.PortType.jmxManager); - } - - int testRate = 2000; - - CommandStringBuilder setStatSampleRate = new CommandStringBuilder(ALTER_RUNTIME_CONFIG) - .addOption(MEMBER, server1.getName()) - .addOption(ALTER_RUNTIME_CONFIG__STATISTIC__SAMPLE__RATE, valueOf(testRate)); - - gfsh.executeAndAssertThat(setStatSampleRate.toString()) - .statusIsSuccess(); - - for (MemberVM server : new MemberVM[] {server1, server2}) { - int expectedSampleRate = server == server1 ? testRate : 1000; - - server.invoke(() -> { - InternalCache cache = ClusterStartupRule.getCache(); - DistributionConfig config = cache.getInternalDistributedSystem().getConfig(); - - assertThat(config.getLogFileSizeLimit()) - .isEqualTo(0); - assertThat(config.getArchiveDiskSpaceLimit()) - .isEqualTo(0); - assertThat(config.getStatisticSampleRate()) - .isEqualTo(expectedSampleRate); - assertThat(config.getStatisticArchiveFile().getName()) - .isEqualTo(""); - assertThat(config.getStatisticSamplingEnabled()) - .isTrue(); - assertThat(config.getLogDiskSpaceLimit()) - .isEqualTo(0); - }); - } - } - - @Test - @Parameters({"true", "false"}) - public void alterStatSampleRateWithGroup_updatesSelectedServerConfigs(boolean connectOverHttp) - throws Exception { - Properties props = new Properties(); - props.setProperty(LOG_LEVEL, "error"); - - MemberVM locator = startupRule.startLocatorVM(0, MemberStarterRule::withHttpService); - MemberVM server1 = startupRule.startServerVM(1, props, locator.getPort()); - - props.setProperty(GROUPS, "G1"); - MemberVM server2 = startupRule.startServerVM(2, props, locator.getPort()); - - if (connectOverHttp) { - gfsh.connectAndVerify(locator.getHttpPort(), GfshCommandRule.PortType.http); - } else { - gfsh.connectAndVerify(locator.getJmxPort(), GfshCommandRule.PortType.jmxManager); - } - - int testRate = 2500; - - CommandStringBuilder setStatSampleRate = new CommandStringBuilder(ALTER_RUNTIME_CONFIG) - .addOption(GROUP, "G1") - .addOption(ALTER_RUNTIME_CONFIG__STATISTIC__SAMPLE__RATE, valueOf(testRate)); - - gfsh.executeAndAssertThat(setStatSampleRate.toString()) - .statusIsSuccess(); - - for (MemberVM server : new MemberVM[] {server1, server2}) { - int expectedSampleRate = server == server2 ? testRate : 1000; - - server.invoke(() -> { - InternalCache cache = ClusterStartupRule.getCache(); - DistributionConfig config = cache.getInternalDistributedSystem().getConfig(); - - assertThat(config.getLogFileSizeLimit()) - .isEqualTo(0); - assertThat(config.getArchiveDiskSpaceLimit()) - .isEqualTo(0); - assertThat(config.getStatisticSampleRate()) - .isEqualTo(expectedSampleRate); - assertThat(config.getStatisticArchiveFile().getName()) - .isEqualTo(""); - assertThat(config.getStatisticSamplingEnabled()) - .isTrue(); - assertThat(config.getLogDiskSpaceLimit()) - .isEqualTo(0); - }); - } - } - - @Test - @Parameters({"true", "false"}) - public void alterStatisticSampleRateRangeIsEnforced(boolean connectOverHttp) throws Exception { - - MemberVM locator = startupRule.startLocatorVM(0, MemberStarterRule::withHttpService); - MemberVM server1 = startupRule.startServerVM(1, locator.getPort()); - MemberVM server2 = startupRule.startServerVM(2, locator.getPort()); - - ignoreIllegalArgumentException("Could not set \"statistic-sample-rate\""); - - if (connectOverHttp) { - gfsh.connectAndVerify(locator.getHttpPort(), GfshCommandRule.PortType.http); - } else { - gfsh.connectAndVerify(locator.getJmxPort(), GfshCommandRule.PortType.jmxManager); - } - - CommandStringBuilder setStatSampleRate = new CommandStringBuilder(ALTER_RUNTIME_CONFIG) - .addOption(ALTER_RUNTIME_CONFIG__STATISTIC__SAMPLE__RATE, "99"); - - gfsh.executeAndAssertThat(setStatSampleRate.toString()) - .statusIsError() - .containsOutput("Could not set \"statistic-sample-rate\" to \"99\""); - - setStatSampleRate = new CommandStringBuilder(ALTER_RUNTIME_CONFIG) - .addOption(ALTER_RUNTIME_CONFIG__STATISTIC__SAMPLE__RATE, "60001"); - - gfsh.executeAndAssertThat(setStatSampleRate.toString()) - .statusIsError() - .containsOutput("Could not set \"statistic-sample-rate\" to \"60001\""); - - verifyDefaultConfig(new MemberVM[] {server1, server2}); - } - - @Test - @Parameters({"true", "false"}) - public void alterArchiveDiskSpaceLimit_updatesAllServerConfigs(boolean connectOverHttp) - throws Exception { - Properties props = new Properties(); - props.setProperty(LOG_LEVEL, "error"); - - MemberVM locator = startupRule.startLocatorVM(0, MemberStarterRule::withHttpService); - MemberVM server1 = startupRule.startServerVM(1, props, locator.getPort()); - MemberVM server2 = startupRule.startServerVM(2, props, locator.getPort()); - - if (connectOverHttp) { - gfsh.connectAndVerify(locator.getHttpPort(), GfshCommandRule.PortType.http); - } else { - gfsh.connectAndVerify(locator.getJmxPort(), GfshCommandRule.PortType.jmxManager); - } - - int testLimit = 10; - CommandStringBuilder setArchiveDiskSpaceLimit = new CommandStringBuilder(ALTER_RUNTIME_CONFIG) - .addOption(ALTER_RUNTIME_CONFIG__ARCHIVE__DISK__SPACE__LIMIT, valueOf(testLimit)); - - gfsh.executeAndAssertThat(setArchiveDiskSpaceLimit.toString()) - .statusIsSuccess(); - - for (MemberVM server : new MemberVM[] {server1, server2}) { - server.invoke(() -> { - InternalCache cache = ClusterStartupRule.getCache(); - DistributionConfig config = cache.getInternalDistributedSystem().getConfig(); - - assertThat(config.getLogFileSizeLimit()) - .isEqualTo(0); - assertThat(config.getArchiveDiskSpaceLimit()) - .isEqualTo(testLimit); - assertThat(config.getArchiveFileSizeLimit()) - .isEqualTo(0); - assertThat(config.getStatisticSampleRate()) - .isEqualTo(1000); - assertThat(config.getStatisticArchiveFile().getName()) - .isEqualTo(""); - assertThat(config.getStatisticSamplingEnabled()) - .isTrue(); - assertThat(config.getLogDiskSpaceLimit()) - .isEqualTo(0); - }); - } - } - - @Test - @Parameters({"true", "false"}) - public void alterArchiveDiskSpaceLimitWithMember_updatesSelectedServerConfigs( - boolean connectOverHttp) throws Exception { - Properties props = new Properties(); - props.setProperty(LOG_LEVEL, "error"); - - MemberVM locator = startupRule.startLocatorVM(0, MemberStarterRule::withHttpService); - MemberVM server1 = startupRule.startServerVM(1, props, locator.getPort()); - MemberVM server2 = startupRule.startServerVM(2, props, locator.getPort()); - - if (connectOverHttp) { - gfsh.connectAndVerify(locator.getHttpPort(), GfshCommandRule.PortType.http); - } else { - gfsh.connectAndVerify(locator.getJmxPort(), GfshCommandRule.PortType.jmxManager); - } - - int testLimit = 10; - - CommandStringBuilder setArchiveDiskSpaceLimit = new CommandStringBuilder(ALTER_RUNTIME_CONFIG) - .addOption(MEMBER, server1.getName()) - .addOption(ALTER_RUNTIME_CONFIG__ARCHIVE__DISK__SPACE__LIMIT, valueOf(testLimit)); - - gfsh.executeAndAssertThat(setArchiveDiskSpaceLimit.toString()) - .statusIsSuccess(); - - for (MemberVM server : new MemberVM[] {server1, server2}) { - int expectedLimit = server == server1 ? testLimit : 0; - - server.invoke(() -> { - InternalCache cache = ClusterStartupRule.getCache(); - DistributionConfig config = cache.getInternalDistributedSystem().getConfig(); - - assertThat(config.getLogFileSizeLimit()) - .isEqualTo(0); - assertThat(config.getArchiveDiskSpaceLimit()) - .isEqualTo(expectedLimit); - assertThat(config.getArchiveFileSizeLimit()) - .isEqualTo(0); - assertThat(config.getStatisticSampleRate()) - .isEqualTo(1000); - assertThat(config.getStatisticArchiveFile().getName()) - .isEqualTo(""); - assertThat(config.getStatisticSamplingEnabled()) - .isTrue(); - assertThat(config.getLogDiskSpaceLimit()) - .isEqualTo(0); - }); - } - } - - @Test - @Parameters({"true", "false"}) - public void alterArchiveDiskSpaceLimitWithGroup_updatesSelectedServerConfigs( - boolean connectOverHttp) throws Exception { - Properties props = new Properties(); - props.setProperty(LOG_LEVEL, "error"); - - MemberVM locator = startupRule.startLocatorVM(0, MemberStarterRule::withHttpService); - MemberVM server1 = startupRule.startServerVM(1, props, locator.getPort()); - - props.setProperty(GROUPS, "G1"); - MemberVM server2 = startupRule.startServerVM(2, props, locator.getPort()); - - if (connectOverHttp) { - gfsh.connectAndVerify(locator.getHttpPort(), GfshCommandRule.PortType.http); - } else { - gfsh.connectAndVerify(locator.getJmxPort(), GfshCommandRule.PortType.jmxManager); - } - - int testLimit = 25; - - CommandStringBuilder setArchiveDiskSpaceLimit = new CommandStringBuilder(ALTER_RUNTIME_CONFIG) - .addOption(GROUP, "G1") - .addOption(ALTER_RUNTIME_CONFIG__ARCHIVE__DISK__SPACE__LIMIT, valueOf(testLimit)); - - gfsh.executeAndAssertThat(setArchiveDiskSpaceLimit.toString()) - .statusIsSuccess(); - - for (MemberVM server : new MemberVM[] {server1, server2}) { - int expectedLimit = server == server2 ? testLimit : 0; - - server.invoke(() -> { - InternalCache cache = ClusterStartupRule.getCache(); - DistributionConfig config = cache.getInternalDistributedSystem().getConfig(); - - assertThat(config.getLogFileSizeLimit()) - .isEqualTo(0); - assertThat(config.getArchiveDiskSpaceLimit()) - .isEqualTo(expectedLimit); - assertThat(config.getArchiveFileSizeLimit()) - .isEqualTo(0); - assertThat(config.getStatisticSampleRate()) - .isEqualTo(1000); - assertThat(config.getStatisticArchiveFile().getName()) - .isEqualTo(""); - assertThat(config.getStatisticSamplingEnabled()) - .isTrue(); - assertThat(config.getLogDiskSpaceLimit()) - .isEqualTo(0); - }); - } - } - - @Test - @Parameters({"true", "false"}) - public void alterArchiveDiskSpaceLimitRangeIsEnforced(boolean connectOverHttp) throws Exception { - - MemberVM locator = startupRule.startLocatorVM(0, MemberStarterRule::withHttpService); - MemberVM server1 = startupRule.startServerVM(1, locator.getPort()); - MemberVM server2 = startupRule.startServerVM(2, locator.getPort()); - - ignoreIllegalArgumentException("Could not set \"archive-disk-space-limit"); - if (connectOverHttp) { - gfsh.connectAndVerify(locator.getHttpPort(), GfshCommandRule.PortType.http); - } else { - gfsh.connectAndVerify(locator.getJmxPort(), GfshCommandRule.PortType.jmxManager); - } - - CommandStringBuilder setArchiveDiskSpaceLimit = new CommandStringBuilder(ALTER_RUNTIME_CONFIG) - .addOption(ALTER_RUNTIME_CONFIG__ARCHIVE__DISK__SPACE__LIMIT, "-1"); - - gfsh.executeAndAssertThat(setArchiveDiskSpaceLimit.toString()) - .statusIsError() - .containsOutput("Could not set \"archive-disk-space-limit\" to \"-1\""); - - setArchiveDiskSpaceLimit = new CommandStringBuilder(ALTER_RUNTIME_CONFIG) - .addOption(ALTER_RUNTIME_CONFIG__ARCHIVE__DISK__SPACE__LIMIT, "1000001"); - - gfsh.executeAndAssertThat(setArchiveDiskSpaceLimit.toString()) - .statusIsError() - .containsOutput("Could not set \"archive-disk-space-limit\" to \"1000001\""); - - for (MemberVM server : new MemberVM[] {server1, server2}) { - server.invoke(() -> { - InternalCache cache = ClusterStartupRule.getCache(); - DistributionConfig config = cache.getInternalDistributedSystem().getConfig(); - - assertThat(config.getLogFileSizeLimit()) - .isEqualTo(0); - assertThat(config.getArchiveDiskSpaceLimit()) - .isEqualTo(0); - assertThat(config.getArchiveFileSizeLimit()) - .isEqualTo(0); - assertThat(config.getStatisticSampleRate()) - .isEqualTo(1000); - assertThat(config.getStatisticArchiveFile().getName()) - .isEqualTo(""); - assertThat(config.getStatisticSamplingEnabled()) - .isTrue(); - assertThat(config.getLogDiskSpaceLimit()) - .isEqualTo(0); - }); - } - } - - @Test - @Parameters({"true", "false"}) - public void alterArchiveFileSizeLimit_updatesAllServerConfigs(boolean connectOverHttp) - throws Exception { - Properties props = new Properties(); - props.setProperty(LOG_LEVEL, "error"); - - MemberVM locator = startupRule.startLocatorVM(0, MemberStarterRule::withHttpService); - MemberVM server1 = startupRule.startServerVM(1, props, locator.getPort()); - MemberVM server2 = startupRule.startServerVM(2, props, locator.getPort()); - - if (connectOverHttp) { - gfsh.connectAndVerify(locator.getHttpPort(), GfshCommandRule.PortType.http); - } else { - gfsh.connectAndVerify(locator.getJmxPort(), GfshCommandRule.PortType.jmxManager); - } - - int testLimit = 10; - - CommandStringBuilder setArchiveFileSizeLimit = new CommandStringBuilder(ALTER_RUNTIME_CONFIG) - .addOption(ALTER_RUNTIME_CONFIG__ARCHIVE__FILE__SIZE__LIMIT, valueOf(testLimit)); - - gfsh.executeAndAssertThat(setArchiveFileSizeLimit.toString()) - .statusIsSuccess(); - - for (MemberVM server : new MemberVM[] {server1, server2}) { - server.invoke(() -> { - InternalCache cache = ClusterStartupRule.getCache(); - DistributionConfig config = cache.getInternalDistributedSystem().getConfig(); - - assertThat(config.getLogFileSizeLimit()) - .isEqualTo(0); - assertThat(config.getArchiveDiskSpaceLimit()) - .isEqualTo(0); - assertThat(config.getArchiveFileSizeLimit()) - .isEqualTo(testLimit); - assertThat(config.getStatisticSampleRate()) - .isEqualTo(1000); - assertThat(config.getStatisticArchiveFile().getName()) - .isEqualTo(""); - assertThat(config.getStatisticSamplingEnabled()) - .isTrue(); - assertThat(config.getLogDiskSpaceLimit()) - .isEqualTo(0); - }); - } - } - - @Test - @Parameters({"true", "false"}) - public void alterArchiveFileSizeLimitWithMember_updatesSelectedServerConfigs( - boolean connectOverHttp) throws Exception { - Properties props = new Properties(); - props.setProperty(LOG_LEVEL, "error"); - - MemberVM locator = startupRule.startLocatorVM(0, MemberStarterRule::withHttpService); - MemberVM server1 = startupRule.startServerVM(1, props, locator.getPort()); - MemberVM server2 = startupRule.startServerVM(2, props, locator.getPort()); - - if (connectOverHttp) { - gfsh.connectAndVerify(locator.getHttpPort(), GfshCommandRule.PortType.http); - } else { - gfsh.connectAndVerify(locator.getJmxPort(), GfshCommandRule.PortType.jmxManager); - } - - int testLimit = 10; - - CommandStringBuilder setArchiveFileSizeLimit = new CommandStringBuilder(ALTER_RUNTIME_CONFIG) - .addOption(MEMBER, server1.getName()) - .addOption(ALTER_RUNTIME_CONFIG__ARCHIVE__FILE__SIZE__LIMIT, valueOf(testLimit)); - - gfsh.executeAndAssertThat(setArchiveFileSizeLimit.toString()) - .statusIsSuccess(); - - for (MemberVM server : new MemberVM[] {server1, server2}) { - int expectedLimit = server == server1 ? testLimit : 0; - - server.invoke(() -> { - InternalCache cache = ClusterStartupRule.getCache(); - DistributionConfig config = cache.getInternalDistributedSystem().getConfig(); - - assertThat(config.getLogFileSizeLimit()) - .isEqualTo(0); - assertThat(config.getArchiveDiskSpaceLimit()) - .isEqualTo(0); - assertThat(config.getArchiveFileSizeLimit()) - .isEqualTo(expectedLimit); - assertThat(config.getStatisticSampleRate()) - .isEqualTo(1000); - assertThat(config.getStatisticArchiveFile().getName()) - .isEqualTo(""); - assertThat(config.getStatisticSamplingEnabled()) - .isTrue(); - assertThat(config.getLogDiskSpaceLimit()) - .isEqualTo(0); - }); - } - } - - @Test - @Parameters({"true", "false"}) - public void alterArchiveFileSizeLimitWithGroup_updatesSelectedServerConfigs( - boolean connectOverHttp) throws Exception { - Properties props = new Properties(); - props.setProperty(LOG_LEVEL, "error"); - - MemberVM locator = startupRule.startLocatorVM(0, MemberStarterRule::withHttpService); - MemberVM server1 = startupRule.startServerVM(1, props, locator.getPort()); - - props.setProperty(GROUPS, "G1"); - MemberVM server2 = startupRule.startServerVM(2, props, locator.getPort()); - - if (connectOverHttp) { - gfsh.connectAndVerify(locator.getHttpPort(), GfshCommandRule.PortType.http); - } else { - gfsh.connectAndVerify(locator.getJmxPort(), GfshCommandRule.PortType.jmxManager); - } - - int testLimit = 25; - - CommandStringBuilder setArchiveFileSizeLimit = new CommandStringBuilder(ALTER_RUNTIME_CONFIG) - .addOption(GROUP, "G1") - .addOption(ALTER_RUNTIME_CONFIG__ARCHIVE__FILE__SIZE__LIMIT, valueOf(testLimit)); - - gfsh.executeAndAssertThat(setArchiveFileSizeLimit.toString()) - .statusIsSuccess(); - - for (MemberVM server : new MemberVM[] {server1, server2}) { - int expectedLimit = server == server2 ? testLimit : 0; - - server.invoke(() -> { - InternalCache cache = ClusterStartupRule.getCache(); - DistributionConfig config = cache.getInternalDistributedSystem().getConfig(); - - assertThat(config.getLogFileSizeLimit()) - .isEqualTo(0); - assertThat(config.getArchiveDiskSpaceLimit()) - .isEqualTo(0); - assertThat(config.getArchiveFileSizeLimit()) - .isEqualTo(expectedLimit); - assertThat(config.getStatisticSampleRate()) - .isEqualTo(1000); - assertThat(config.getStatisticArchiveFile().getName()) - .isEqualTo(""); - assertThat(config.getStatisticSamplingEnabled()) - .isTrue(); - assertThat(config.getLogDiskSpaceLimit()) - .isEqualTo(0); - }); - } - } - - @Test - @Parameters({"true", "false"}) - public void alterArchiveFileSizeLimitRangeIsEnforced(boolean connectOverHttp) throws Exception { - - MemberVM locator = startupRule.startLocatorVM(0, MemberStarterRule::withHttpService); - MemberVM server1 = startupRule.startServerVM(1, locator.getPort()); - MemberVM server2 = startupRule.startServerVM(2, locator.getPort()); - - ignoreIllegalArgumentException("Could not set \"archive-file-size-limit\""); - if (connectOverHttp) { - gfsh.connectAndVerify(locator.getHttpPort(), GfshCommandRule.PortType.http); - } else { - gfsh.connectAndVerify(locator.getJmxPort(), GfshCommandRule.PortType.jmxManager); - } - - CommandStringBuilder setArchiveFileSizeLimit = new CommandStringBuilder(ALTER_RUNTIME_CONFIG) - .addOption(ALTER_RUNTIME_CONFIG__ARCHIVE__FILE__SIZE__LIMIT, "-1"); - - gfsh.executeAndAssertThat(setArchiveFileSizeLimit.toString()) - .statusIsError() - .containsOutput("Could not set \"archive-file-size-limit\" to \"-1\""); - - setArchiveFileSizeLimit = new CommandStringBuilder(ALTER_RUNTIME_CONFIG) - .addOption(ALTER_RUNTIME_CONFIG__ARCHIVE__FILE__SIZE__LIMIT, "1000001"); - - gfsh.executeAndAssertThat(setArchiveFileSizeLimit.toString()) - .statusIsError() - .containsOutput("Could not set \"archive-file-size-limit\" to \"1000001\""); - - verifyDefaultConfig(new MemberVM[] {server1, server2}); - } - - @Test - @Parameters({"true", "false"}) - public void alterDisableStatisticSampling(boolean connectOverHttp) throws Exception { - Properties props = new Properties(); - props.setProperty(LOG_LEVEL, "error"); - - MemberVM locator = startupRule.startLocatorVM(0, MemberStarterRule::withHttpService); - MemberVM server1 = startupRule.startServerVM(1, props, locator.getPort()); - MemberVM server2 = startupRule.startServerVM(2, props, locator.getPort()); - - if (connectOverHttp) { - gfsh.connectAndVerify(locator.getHttpPort(), GfshCommandRule.PortType.http); - } else { - gfsh.connectAndVerify(locator.getJmxPort(), GfshCommandRule.PortType.jmxManager); - } - - CommandStringBuilder setStatSamplingEnabled = new CommandStringBuilder(ALTER_RUNTIME_CONFIG) - .addOption(ALTER_RUNTIME_CONFIG__STATISTIC__SAMPLING__ENABLED, "false"); - - gfsh.executeAndAssertThat(setStatSamplingEnabled.toString()) - .statusIsSuccess(); - - for (MemberVM server : new MemberVM[] {server1, server2}) { - server.invoke(() -> { - InternalCache cache = ClusterStartupRule.getCache(); - DistributionConfig config = cache.getInternalDistributedSystem().getConfig(); - - assertThat(config.getLogFileSizeLimit()) - .isEqualTo(0); - assertThat(config.getArchiveDiskSpaceLimit()) - .isEqualTo(0); - assertThat(config.getStatisticSampleRate()) - .isEqualTo(1000); - assertThat(config.getStatisticArchiveFile().getName()) - .isEqualTo(""); - assertThat(config.getStatisticSamplingEnabled()) - .isFalse(); - assertThat(config.getLogDiskSpaceLimit()) - .isEqualTo(0); - }); - } - } - - /** - * Test to verify that when 'alter runtime' without relevant options does not change the server's - * configuration - */ - @Test - @Parameters({"true", "false"}) - public void alterGroupWithoutOptions_needsRelevantParameter(boolean connectOverHttp) - throws Exception { - Properties props = new Properties(); - props.setProperty(LOG_LEVEL, "error"); - - MemberVM locator = startupRule.startLocatorVM(0, MemberStarterRule::withHttpService); - MemberVM server1 = startupRule.startServerVM(1, props, locator.getPort()); - - props.setProperty(GROUPS, "G1"); - MemberVM server2 = startupRule.startServerVM(2, props, locator.getPort()); - - if (connectOverHttp) { - gfsh.connectAndVerify(locator.getHttpPort(), GfshCommandRule.PortType.http); - } else { - gfsh.connectAndVerify(locator.getJmxPort(), GfshCommandRule.PortType.jmxManager); - } - - server2.invoke(() -> { - InternalCache cache = ClusterStartupRule.getCache(); - DistributionConfig config = cache.getInternalDistributedSystem().getConfig(); - - assertThat(config.getGroups()) - .isEqualTo("G1"); - }); - - CommandStringBuilder withGroupOnly = new CommandStringBuilder(ALTER_RUNTIME_CONFIG) - .addOption(GROUP, "G1"); - - gfsh.executeAndAssertThat(withGroupOnly.toString()) - .statusIsError() - .containsOutput(ALTER_RUNTIME_CONFIG__RELEVANT__OPTION__MESSAGE); - - server1.invoke(() -> { - InternalCache cache = ClusterStartupRule.getCache(); - DistributionConfig config = cache.getInternalDistributedSystem().getConfig(); - - assertThat(config.getLogFileSizeLimit()) - .isEqualTo(0); - assertThat(config.getLogDiskSpaceLimit()) - .isEqualTo(0); - assertThat(config.getArchiveDiskSpaceLimit()) - .isEqualTo(0); - assertThat(config.getStatisticSampleRate()) - .isEqualTo(1000); - assertThat(config.getStatisticArchiveFile().getName()) - .isEqualTo(""); - assertThat(config.getStatisticSamplingEnabled()) - .isTrue(); - }); - } - - /** - * Test to verify that when 'alter runtime' without relevant options does not change the server's - * configuration - */ - @Test - @Parameters({"true", "false"}) - public void alterMemberWithoutOptions_needsRelevantParameter(boolean connectOverHttp) - throws Exception { - Properties props = new Properties(); - props.setProperty(LOG_LEVEL, "error"); - - MemberVM locator = startupRule.startLocatorVM(0, MemberStarterRule::withHttpService); - MemberVM server1 = startupRule.startServerVM(1, props, locator.getPort()); - - if (connectOverHttp) { - gfsh.connectAndVerify(locator.getHttpPort(), GfshCommandRule.PortType.http); - } else { - gfsh.connectAndVerify(locator.getJmxPort(), GfshCommandRule.PortType.jmxManager); - } - - CommandStringBuilder withMemberOnly = new CommandStringBuilder(ALTER_RUNTIME_CONFIG) - .addOption(MEMBER, server1.getName()); - - gfsh.executeAndAssertThat(withMemberOnly.toString()) - .statusIsError() - .containsOutput(ALTER_RUNTIME_CONFIG__RELEVANT__OPTION__MESSAGE); - - server1.invoke(() -> { - InternalCache cache = ClusterStartupRule.getCache(); - DistributionConfig config = cache.getInternalDistributedSystem().getConfig(); - - assertThat(config.getLogFileSizeLimit()) - .isEqualTo(0); - assertThat(config.getLogDiskSpaceLimit()) - .isEqualTo(0); - assertThat(config.getArchiveDiskSpaceLimit()) - .isEqualTo(0); - assertThat(config.getStatisticSampleRate()) - .isEqualTo(1000); - assertThat(config.getStatisticArchiveFile().getName()) - .isEqualTo(""); - assertThat(config.getStatisticSamplingEnabled()) - .isTrue(); - }); - } - - @Test - @Parameters({"true", "false"}) - public void testAlterUpdatesSharedConfig(boolean connectOverHttp) throws Exception { - MemberVM locator = startupRule.startLocatorVM(0, MemberStarterRule::withHttpService); - - if (connectOverHttp) { - gfsh.connectAndVerify(locator.getHttpPort(), GfshCommandRule.PortType.http); - } else { - gfsh.connectAndVerify(locator.getJmxPort(), GfshCommandRule.PortType.jmxManager); - } - - Properties props = new Properties(); - props.setProperty(GROUPS, "Group1"); - props.setProperty(LOG_LEVEL, "error"); - - startupRule.startServerVM(1, props, locator.getPort()); - - String command = "alter runtime --group=Group1 --log-level=fine"; - gfsh.executeAndAssertThat(command) - .statusIsSuccess(); - - locator.invoke(() -> { - Properties properties = ClusterStartupRule.getLocator().getConfigurationPersistenceService() - .getConfiguration("Group1") - .getGemfireProperties(); - - assertThat(properties.get(LOG_LEVEL)) - .isEqualTo("fine"); - }); - } - - private void verifyDefaultConfig(MemberVM[] servers) { - for (MemberVM server : servers) { - server.invoke(() -> { - InternalCache cache = ClusterStartupRule.getCache(); - DistributionConfig config = cache.getInternalDistributedSystem().getConfig(); - - assertThat(config.getLogLevel()) - .isEqualTo(LogWriterLevel.CONFIG.intLevel()); - assertThat(config.getLogFileSizeLimit()) - .isEqualTo(0); - assertThat(config.getArchiveDiskSpaceLimit()) - .isEqualTo(0); - assertThat(config.getStatisticSampleRate()) - .isEqualTo(1000); - assertThat(config.getStatisticArchiveFile().getName()) - .isEqualTo(""); - assertThat(config.getStatisticSamplingEnabled()) - .isTrue(); - assertThat(config.getLogDiskSpaceLimit()) - .isEqualTo(0); - }); - } - } - + // @Test Review comment: Why are these tests commented out? ########## File path: geode-management/src/main/resources/org/apache/geode/management/internal/sanctioned-geode-management-serializables.txt ########## @@ -6,7 +6,7 @@ org/apache/geode/management/api/RealizationResult,false,memberName:java/lang/Str org/apache/geode/management/configuration/AbstractConfiguration,true,-6612840641128145954 org/apache/geode/management/configuration/AutoSerializer,true,1,patterns:java/util/List,portable:java/lang/Boolean org/apache/geode/management/configuration/ClassName,true,1,className:java/lang/String,initProperties:java/util/Properties -org/apache/geode/management/configuration/Deployment,true,6992732279452865384,deployedBy:java/lang/String,deployedTime:java/lang/String,jarFileName:java/lang/String +org/apache/geode/management/configuration/Deployment,true,6992732279452865384,dependencies:java/util/List,deployedBy:java/lang/String,deployedTime:java/lang/String,jarFileName:java/lang/String Review comment: would change this cause any upgrade issue? 'cause I seem to remember this is saved in an internal region, see `Configuration` class which holds reference to this class. See `ConfigurationCompatibilityTest` for example. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
