gaussianrecurrence commented on a change in pull request #891:
URL: https://github.com/apache/geode-native/pull/891#discussion_r813199054



##########
File path: cppcache/src/PdxRemoteWriter.hpp
##########
@@ -22,11 +22,13 @@
 
 #include "PdxLocalWriter.hpp"
 
+#include <geode/internal/geode_globals.hpp>
+
 namespace apache {
 namespace geode {
 namespace client {
 
-class PdxRemoteWriter : public PdxLocalWriter {
+class APACHE_GEODE_EXPORT PdxRemoteWriter : public PdxLocalWriter {

Review comment:
       This is exported for testing purposes. Will try to test it the way 
@pivotal-jbarrett, which would avoid exporting symbols.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to