pdxcodemonkey commented on a change in pull request #938:
URL: https://github.com/apache/geode-native/pull/938#discussion_r817974196
##########
File path: cppcache/src/TcrConnection.cpp
##########
@@ -380,33 +386,33 @@ bool TcrConnection::initTcrConnection(
}
switch (acceptanceCode[0]) {
- case REPLY_OK:
- case SUCCESSFUL_SERVER_TO_CLIENT:
+ case static_cast<int>(acceptance_codes::REPLY_OK):
Review comment:
Oh right, we could just cast the byte we read rather than cast in every
case statement. That's way better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]