boglesby commented on a change in pull request #7375:
URL: https://github.com/apache/geode/pull/7375#discussion_r819745386
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegionDataStore.java
##########
@@ -2953,7 +2953,7 @@ public void executeOnDataStore(final Set localKeys, final
Function function, fin
long start = stats.startFunctionExecution(function.hasResult());
try {
if (logger.isDebugEnabled()) {
- logger.debug("Executing Function: {} on Remote Node with context: ",
function.getId(),
+ logger.debug("Executing Function:{} on Remote Node with context: {}",
function.getId(),
Review comment:
The space was removed in `Function:{}`. It probably should also be
removed in `context: {}`
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegion.java
##########
@@ -5613,7 +5613,7 @@ public void cleanupFailedInitialization() {
}
if (savedFirstRuntimeException != null
&& savedFirstRuntimeException instanceof
DistributedSystemDisconnectedException) {
- logger.warn("cleanupFailedInitialization originally failed with {}",
+ logger.warn("cleanupFailedInitialization originally failed with: ",
Review comment:
I like having the stack on warnings.
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/BucketRegionQueue.java
##########
@@ -146,7 +146,7 @@ private void initializeEventSeqNumQueue() {
if (logger.isDebugEnabled()) {
logger.debug(
- "For bucket {} ,total keys recovered are : {} last key recovered
is : {} and the seqNo is ",
+ "For bucket: {} ,total keys recovered are: {} last key recovered
is: {} and the seqNo is: {}",
Review comment:
This: `{} ,` should be this: `{}, `. Also there are no commas in the
rest of that message, so maybe the comma should be removed altogether.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
