BalaKaza commented on a change in pull request #7429:
URL: https://github.com/apache/geode/pull/7429#discussion_r822049880
##########
File path:
geode-for-redis/src/main/java/org/apache/geode/redis/internal/data/AbstractRedisData.java
##########
@@ -218,7 +230,14 @@ public void toDelta(DataOutput out) throws IOException {
@Override
public void fromDelta(DataInput in) throws IOException,
InvalidDeltaException {
+ short deltaVersion = DataSerializer.readPrimitiveShort(in);
DeltaType deltaType = readEnum(DeltaType.class, in);
+
+ if (deltaType.isVersioned() && deltaVersion == getVersion()) {
+ return;
+ }
+ setVersion(deltaVersion);
Review comment:
DeltaDUnitTest and PartitionedRegionStatsUpdateTest tests were failing
because of `setVersion(deltaVersion)` because ValueAppend increments the
version. So every other delta was skipped because after `valueAppend` the
version was one more than expected. Commenting out the `setVersion` made the
DunitTests pass not sure if there are any side effects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
