DonalEvans opened a new pull request #7437:
URL: https://github.com/apache/geode/pull/7437
Code changes:
- Rather than a value that updates once per second, instantaneous
operations per second and instantaneous kilobytes read per second now
return a rolling average of those stats updated 16 times per second
- Change instantaneous operations per second type from double to int,
since it's always a whole number
- Introduce RollingAverageStat nested class in RedisStats to handle
calculating the rolling average value of a given stat
Test changes:
- Rename AbstractRedisInfoStatsIntegrationTest to match child classes
- Rather than measuring instantaneous per second stats after
operations have finished, sample them while operations are ongoing
- Assert only that the stats have updated, not that they are close to a
calculated expected value, as this proved too inconsistent and very
flaky
Authored-by: Donal Evans <[email protected]>
<!-- Thank you for submitting a contribution to Apache Geode. -->
<!-- In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
-->
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
<!-- Note:
Please ensure that once the PR is submitted, check Concourse for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to [email protected].
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
