kirklund commented on a change in pull request #7416:
URL: https://github.com/apache/geode/pull/7416#discussion_r825187076



##########
File path: 
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/MessageDispatcher.java
##########
@@ -193,6 +194,15 @@ public boolean isWaitingForReAuthentication() {
     return waitForReAuthenticationStartTime > 0;
   }
 
+  private volatile boolean subjectUpdated = false;
+
+  public void notifyReAuthentication() {
+    synchronized (re_auth_lock) {
+      subjectUpdated = true;
+      re_auth_lock.notify();

Review comment:
       You always want to use `notifyAll()` instead of `notify()`. I don't 
remember exact reasons off the top of my head but I probably picked it up most 
recently from Java Concurrency in Practice by Brian Goetz.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to