agingade commented on a change in pull request #7441:
URL: https://github.com/apache/geode/pull/7441#discussion_r825198829
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/AbstractRegionMap.java
##########
@@ -384,8 +365,7 @@ public void close(BucketRegion bucketRegion) {
RegionVersionVector localRvv = lr.getVersionVector();
incClearCount(lr);
// lock for size calcs if the region might have tombstones
- Object lockObj = lr.getConcurrencyChecksEnabled() ? lr.getSizeGuard() :
new Object();
- synchronized (lockObj) {
+ synchronized (lr.getSizeGuard()) {
Review comment:
This doesn't seem to be just removal of unused code; from the code it
looks like it was not taking any lock (to avoid concurrent access) when
concurrency check was not enabled; now it takes lock all the time.
Is this a fix for an issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
