jchen21 commented on a change in pull request #7440:
URL: https://github.com/apache/geode/pull/7440#discussion_r827385315



##########
File path: 
geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/RegionAdvisor.java
##########
@@ -426,6 +430,23 @@ public void removeIdAndBuckets(InternalDistributedMember 
memberId, int prSerial,
     }
   }
 
+  public void removeIdAndBucket(int bucketId, InternalDistributedMember 
memberId, int serial,
+      boolean regionDestroyed) {
+    synchronized (preInitQueueMonitor) {
+      if (preInitQueue != null) {
+        // Queue profile during pre-initialization
+        QueuedBucketProfile qbf =
+            new QueuedBucketProfile(bucketId, memberId, serial, 
regionDestroyed);
+        preInitQueue.add(qbf);
+        return;
+      }
+    }
+
+    if (buckets != null) {

Review comment:
       If `buckets` is `null`, which means `initializeRegionAdvisor()` and 
`processProfilesQueuedDuringInitialization()` are not called yet. At this time, 
as long as `RegionAdvisor` constructor is called, `preInitQueue` is not `null`. 
It will enqueue the bucket profile and `return` in the `if (preInitQueue != 
null)` block line 441.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to