boglesby commented on pull request #7391: URL: https://github.com/apache/geode/pull/7391#issuecomment-1079449538
Without these changes, I see AbstractGatewaySender.distribute being invoked by a P2P message reader when it is processing either a PutMessage (primary) or UpdateMessage (secondary): Primary: ``` P2P message reader for 192.168.1.3(ny-1:17684)<v36>:41002 unshared ordered sender uid=9 dom #1 local port=47104 remote port=58047: PutMessage.fromData key=0; generateCallbacks=true P2P message reader for 192.168.1.3(ny-1:17684)<v36>:41002 unshared ordered sender uid=9 dom #1 local port=47104 remote port=58047: AbstractGatewaySender.distribute key=0 ``` Secondary: ``` P2P message reader for 192.168.1.3(ny-2:17701)<v37>:41003 unshared ordered sender uid=10 dom #2 local port=45569 remote port=58050: UpdateMessage.fromData key=3; generateCallbacks=true P2P message reader for 192.168.1.3(ny-2:17701)<v37>:41003 unshared ordered sender uid=10 dom #2 local port=45569 remote port=58050: AbstractGatewaySender.distribute key=3 ``` With these changes, generateCallbacks is false in both cases, and AbstractGatewaySender.distribute is not invoked. Partitioned Region with Parallel Sender --------------------------------------- A ServerConnection receives the put operation and sends a PutMessage with generateCallbacks=false to the secondary: ``` ServerConnection on port 5397 Thread 2: PutMessage.toData key=0; generateCallbacks=false; extraFlagsByte=1001010 ``` A P2P message reader in the secondary reads generateCallbacks=false and does not invoke the AbstractGatewaySender.distribute method: ``` P2P message reader for 192.168.1.3(ny-1:15993)<v20>:41002 unshared ordered sender uid=9 dom #1 local port=50485 remote port=56630: PutMessage.fromData key=0; generateCallbacks=false P2P message reader for 192.168.1.3(ny-2:16012)<v21>:41003 unshared ordered sender uid=10 dom #2 local port=44046 remote port=56632: UpdateMessage.fromData key=0; generateCallbacks=false ``` The same behavior occurs with UpdateMessage: ``` ServerConnection on port 5185 Thread 2: UpdateMessage.toData key=1; generateCallbacks=false; extraFlagsByte=101010 P2P message reader for 192.168.1.3(ny-2:16012)<v21>:41003 unshared ordered sender uid=9 dom #1 local port=44046 remote port=56631: UpdateMessage.fromData key=1; generateCallbacks=false ``` Partitioned Region with Serial Sender ------------------------------------- I see the same correct behavior. PutMessage from receiver to primary: ``` ServerConnection on port 5489 Thread 2: PutMessage.toData key=4; generateCallbacks=false; extraFlagsByte=1001010 P2P message reader for 192.168.1.3(ny-1:30559)<v145>:41002 unshared ordered sender uid=9 dom #1 local port=57717 remote port=49677: PutMessage.fromData key=4; generateCallbacks=false ``` UpdateMessage from receiver to secondary: ``` ServerConnection on port 5489 Thread 2: UpdateMessage.toData key=7; generateCallbacks=false; extraFlagsByte=101010 P2P message reader for 192.168.1.3(ny-1:30559)<v145>:41002 unshared ordered sender uid=9 dom #1 local port=57717 remote port=49677: UpdateMessage.fromData key=7; generateCallbacks=false ``` Replicated Region with Serial Sender ------------------------------------ I see the same correct behavior. UpdateMessage from receiver to replicate: ``` ServerConnection on port 5078 Thread 2: UpdateMessage.toData key=2; generateCallbacks=false; extraFlagsByte=101010 P2P message reader for 192.168.1.3(ny-1:18935)<v59>:41002 unshared ordered sender uid=9 dom #1 local port=51500 remote port=59592: UpdateMessage.fromData key=2; generateCallbacks=false ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
