Bill commented on a change in pull request #7449:
URL: https://github.com/apache/geode/pull/7449#discussion_r835650778
##########
File path: geode-core/src/main/java/org/apache/geode/internal/net/NioFilter.java
##########
@@ -35,7 +35,7 @@
* Be sure to call close() on the returned {@link ByteBufferSharing}. The
best way to do that is
* to call this method in a try-with-resources statement.
*/
- ByteBufferSharing wrap(ByteBuffer buffer) throws IOException;
+ ByteBufferSharing wrap(ByteBuffer buffer, final SocketChannel channel)
throws IOException;
Review comment:
`wrap()` now must take a `SocketChannel` parameter because `wrap()` may
have to write to the channel before returning to the caller.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
