pivotal-jbarrett commented on a change in pull request #7449:
URL: https://github.com/apache/geode/pull/7449#discussion_r837519149
##########
File path:
geode-core/src/distributedTest/java/org/apache/geode/distributed/internal/P2PMessagingConcurrencyDUnitTest.java
##########
@@ -70,28 +77,74 @@
@RunWith(GeodeParamsRunner.class)
public class P2PMessagingConcurrencyDUnitTest {
- // how many messages will each sender generate?
- private static final int MESSAGES_PER_SENDER = 1_000;
+ // how many sending member JVMs
+ private static final int SENDERS = 1;
- // number of concurrent (sending) tasks to run
- private static final int SENDER_COUNT = 10;
+ // number of concurrent (sending) tasks to run in each sending JVM
+ private static final int TASKS_PER_SENDER = 10;
- // (exclusive) upper bound of random message size, in bytes
- private static final int LARGEST_MESSAGE_BOUND = 32 * 1024 + 2; // 32KiB + 2
+ // how many messages will each sending task generate?
+ private static final int MESSAGES_PER_SENDING_TASK = 1_000;
+
+ /*
+ * Upper bound (exclusive) of random message size, in bytes.
+ * The magnitude is chosen to give us a mix of messages around
+ * 16KB. I want a number that results in a largest message that
+ * is not a power of two since I believe, for no particular reason,
+ * that it might catch more bugs than a power of two would,
+ * so I add 2.
+ */
+ private static final int LARGEST_MESSAGE_BOUND = 32 * 1024 + 2;
+
+ /*
+ * Non-random payload content makes debugging easier when a NULL cipher is
used.
+ * Null ciphers are not allowed on TLSv1.3 though.
+ */
+ private static boolean RANDOMIZE_PAYLOAD_CONTENT = true;
Review comment:
I really have mixed feelings about having "debugging code" hanging
around in tests. I feel like if they are worth having for diagnostics in the
case of failures that they are worth having as CI executed tests to avoid the
need to diagnose them in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
