gesterzhou commented on code in PR #7471:
URL: https://github.com/apache/geode/pull/7471#discussion_r841966337
##########
geode-core/src/main/java/org/apache/geode/cache/client/internal/QueueManagerImpl.java:
##########
@@ -853,7 +853,8 @@ void recoverPrimary(Set<ServerLocation> excludedServers) {
return;
}
final boolean isDebugEnabled = logger.isDebugEnabled();
- if (queueConnections.getPrimary() != null &&
!queueConnections.getPrimary().isDestroyed()) {
+ if (queueConnections != null && queueConnections.getPrimary() != null
+ && !queueConnections.getPrimary().isDestroyed()) {
Review Comment:
I feel "redundancySatisfierTask = new RedundancySatisfierTask(this);" could
be a good idea.
There're so many places are accessing queueConnections directly without
checking if it's null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
