pivotal-jbarrett commented on code in PR #7551:
URL: https://github.com/apache/geode/pull/7551#discussion_r842219836
##########
geode-core/src/distributedTest/java/org/apache/geode/internal/statistics/StatisticsDistributedTest.java:
##########
@@ -490,6 +491,49 @@ public void testPubAndSubCustomStats() throws Exception {
combinedUpdateEvents == combinedPuts);
}
+ @Test
+ public void testExistenceOfVMStats() {
+ String regionName = "region_1";
+ VM vm = getHost(0).getVM(0);
+
+ vm.invoke(() -> {
+ Properties props = new Properties();
+ props.setProperty(STATISTIC_SAMPLING_ENABLED, "true");
+ props.setProperty(STATISTIC_SAMPLE_RATE, "1000");
+
+ InternalDistributedSystem system = getSystem(props);
+
+ // assert that sampler is working as expected
+ GemFireStatSampler sampler = system.getStatSampler();
+ assertTrue(sampler.isSamplingEnabled());
Review Comment:
We should make sure the new test is at least written in AssertJ. If the
effort to convert the other tests is small please consider that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
