DonalEvans commented on code in PR #7323:
URL: https://github.com/apache/geode/pull/7323#discussion_r843058215
##########
geode-core/src/main/java/org/apache/geode/internal/cache/BucketAdvisor.java:
##########
@@ -1160,6 +1169,7 @@ private boolean acquiredPrimaryLock() {
try {
synchronized (this) {
if (isHosting() && (isVolunteering() || isBecomingPrimary())) {
+ hasBecomePrimary = isBecomingPrimary();
Review Comment:
I guess the part that I don't understand is what's different between going
from `BECOMING_HOSTING` to `IS_PRIMARY_HOSTING` versus going from
`VOLUNTEERING_HOSTING` to `IS_PRIMARY_HOSTING` that means we only care about
the first case but not the second. In both cases the bucket starts off as not
primary and then becomes primary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
