mhansonp commented on code in PR #7442:
URL: https://github.com/apache/geode/pull/7442#discussion_r843045687
##########
geode-core/src/main/java/org/apache/geode/cache/client/internal/RegisterInterestTracker.java:
##########
@@ -106,7 +108,8 @@ public static int getInterestLookupIndex(boolean isDurable,
boolean receiveUpdat
return result;
}
- void addSingleInterest(final @NotNull LocalRegion r, final @NotNull Object
key,
+ @VisibleForTesting
+ public void addSingleInterest(final @NotNull LocalRegion r, final @NotNull
Object key,
Review Comment:
I am not sure of the benefit. Can you explain that? I understand the basic
security benefit of having package private, but using the visible for testing
will also make something private. What is the difference you are hoping to
preserve? The availability to the rest of the package? If I delete the public,
won't that do the trick?
As far as moving this to somewhere else it seems like I would be making
encapsulation worse. I am open to it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
