jdeppe-pivotal commented on code in PR #7550:
URL: https://github.com/apache/geode/pull/7550#discussion_r843999088


##########
geode-assembly/src/main/dist/bin/gfsh.bat:
##########
@@ -27,7 +27,7 @@ REM
 
 setlocal enableextensions
 set scriptdir=%~dp0
-set gf=%scriptdir:\bin\=%
+set gf=%scriptdir:~0,-4%

Review Comment:
   Could you just add a short comment so anyone else, looking at this in the 
future, knows why `4` in particular. Maybe:
   ```
   REM Remove last 4 chars corresponding to bin\
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to