DonalEvans commented on code in PR #7568:
URL: https://github.com/apache/geode/pull/7568#discussion_r845420845
##########
geode-for-redis/src/main/java/org/apache/geode/redis/internal/data/RedisList.java:
##########
@@ -71,8 +71,7 @@ public RedisList() {
public RedisList(RedisList redisList) {
setExpirationTimestampNoDelta(redisList.getExpirationTimestamp());
setVersion(redisList.getVersion());
Review Comment:
Not really within the scope of this PR, but these two methods are
overridable in `AbstractRedisData`, so they shouldn't really be called in the
constructor (see https://stackoverflow.com/a/3404369). A simple solution is to
make these methods `final` in `AbstractRedisData` so that they're not
overridable, which seems reasonable given they're simple setters for private
fields of that class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
