DonalEvans commented on code in PR #7579:
URL: https://github.com/apache/geode/pull/7579#discussion_r847799209
##########
geode-for-redis/src/main/java/org/apache/geode/redis/internal/data/RedisList.java:
##########
@@ -265,7 +267,7 @@ public void lset(Region<RedisKey, RedisData> region,
RedisKey key, int index, by
throw new RedisException(ERROR_INDEX_OUT_OF_RANGE);
}
- elementReplace(adjustedIndex, value);
+ elementList.set(adjustedIndex, value);
Review Comment:
This call is not inside a synchronized block but modifies the backing list.
Is there a possibility of issues here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
