mmartell commented on code in PR #957:
URL: https://github.com/apache/geode-native/pull/957#discussion_r852466765
##########
cppcache/src/TcrEndpoint.cpp:
##########
@@ -754,42 +754,36 @@ GfErrType TcrEndpoint::sendRequestConn(const TcrMessage&
request,
// TcrMessage * req = const_cast<TcrMessage *>(&request);
LOGDEBUG("TcrEndpoint::sendRequestConn = %p", m_baseDM);
if (m_baseDM != nullptr) m_baseDM->beforeSendingRequest(request, conn);
- if (((type == TcrMessage::EXECUTE_FUNCTION ||
- type == TcrMessage::EXECUTE_REGION_FUNCTION) &&
- (request.hasResult() & 2))) {
- conn->sendRequestForChunkedResponse(request, request.getMsgLength(), reply,
- request.getTimeout(),
- reply.getTimeout());
- } else if (type == TcrMessage::REGISTER_INTEREST_LIST ||
- type == TcrMessage::REGISTER_INTEREST ||
- type == TcrMessage::QUERY ||
- type == TcrMessage::QUERY_WITH_PARAMETERS ||
- type == TcrMessage::GET_ALL_70 ||
- type == TcrMessage::GET_ALL_WITH_CALLBACK ||
- type == TcrMessage::PUTALL ||
- type == TcrMessage::PUT_ALL_WITH_CALLBACK ||
- type == TcrMessage::REMOVE_ALL ||
- ((type == TcrMessage::EXECUTE_FUNCTION ||
- type == TcrMessage::EXECUTE_REGION_FUNCTION) &&
- (request.hasResult() & 2)) ||
- type ==
- TcrMessage::EXECUTE_REGION_FUNCTION_SINGLE_HOP || // This is
- // kept
- // aside as
- // server
- // always
- // sends
- // chunked
- //
response.
- type == TcrMessage::EXECUTECQ_MSG_TYPE ||
- type == TcrMessage::STOPCQ_MSG_TYPE ||
- type == TcrMessage::CLOSECQ_MSG_TYPE ||
- type == TcrMessage::KEY_SET ||
- type == TcrMessage::CLOSECLIENTCQS_MSG_TYPE ||
- type == TcrMessage::GETCQSTATS_MSG_TYPE ||
- type == TcrMessage::MONITORCQ_MSG_TYPE ||
- type == TcrMessage::EXECUTECQ_WITH_IR_MSG_TYPE ||
- type == TcrMessage::GETDURABLECQS_MSG_TYPE) {
+ if (type == TcrMessage::REGISTER_INTEREST_LIST ||
+ type == TcrMessage::REGISTER_INTEREST ||
+ type == TcrMessage::QUERY ||
+ type == TcrMessage::QUERY_WITH_PARAMETERS ||
+ type == TcrMessage::GET_ALL_70 ||
+ type == TcrMessage::GET_ALL_WITH_CALLBACK ||
+ type == TcrMessage::PUTALL ||
+ type == TcrMessage::PUT_ALL_WITH_CALLBACK ||
+ type == TcrMessage::REMOVE_ALL ||
+ ((type == TcrMessage::EXECUTE_FUNCTION ||
+ type == TcrMessage::EXECUTE_REGION_FUNCTION) &&
+ (request.hasResult() & 2)) ||
Review Comment:
I'm not aware of such a PR. Would be a much better for sure. Looks like the
3 bits are:
```uint8_t isHAHasResultOptimizeForWrite = 0;
if (serverIsHA) {
isHAHasResultOptimizeForWrite = isHAHasResultOptimizeForWrite | 1;
}
if (serverHasResult) {
isHAHasResultOptimizeForWrite = isHAHasResultOptimizeForWrite | 2;
}
if (serverOptimizeForWrite) {
isHAHasResultOptimizeForWrite = isHAHasResultOptimizeForWrite | 4;
}
```
But I'd like to see a separate PR for converting all hard coded bit field
numbers to enums.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
