pivotal-jbarrett commented on code in PR #7378:
URL: https://github.com/apache/geode/pull/7378#discussion_r855296399
##########
geode-core/src/test/java/org/apache/geode/distributed/internal/LocatorLoadSnapshotJUnitTest.java:
##########
@@ -631,28 +633,93 @@ public void testFindBestServersCalledWithNegativeCount() {
}
@Test
Review Comment:
Upgrade to JUnit 5.
##########
geode-core/src/main/java/org/apache/geode/distributed/internal/LocatorLoadSnapshot.java:
##########
@@ -413,7 +415,24 @@ public synchronized Map<ServerLocation, ServerLoad>
getLoadMap() {
new ServerLoad(connectionLoad.getLoad(),
connectionLoad.getLoadPerConnection(),
queueLoad.getLoad(), queueLoad.getLoadPerConnection()));
}
+ return result;
+ }
+ @TestOnly
+ public synchronized Map<ServerLocationAndMemberId, ServerLoad>
getGatewayReceiverLoadMap() {
Review Comment:
Does this need to be public for the test or would package private be
sufficient.
##########
geode-core/src/test/java/org/apache/geode/distributed/internal/LocatorLoadSnapshotJUnitTest.java:
##########
@@ -14,6 +14,7 @@
*/
package org.apache.geode.distributed.internal;
+import static org.assertj.core.api.Assertions.assertThat;
import static org.junit.Assert.assertEquals;
Review Comment:
Convert to AssertJ.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
