pivotal-jbarrett commented on code in PR #7603:
URL: https://github.com/apache/geode/pull/7603#discussion_r855400803
##########
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/MessageDispatcher.java:
##########
@@ -83,7 +83,7 @@ public class MessageDispatcher extends LoggingThread {
/**
* Default value in milliseconds for waiting for re-authentication
*/
- private static final long DEFAULT_RE_AUTHENTICATE_WAIT_TIME = 5000;
+ private static final long DEFAULT_RE_AUTHENTICATE_WAIT_TIME = 60 * 1000;
Review Comment:
Please use `Duration` or `TimeUnit` to derive this value so that its very
clear to the reader this is intended as 1 minute in milliseconds.
##########
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/MessageDispatcher.java:
##########
@@ -533,21 +533,28 @@ private boolean
handleAuthenticationExpiredException(AuthenticationExpiredExcept
throws InterruptedException {
long reAuthenticateWaitTime =
getSystemProperty(RE_AUTHENTICATE_WAIT_TIME,
DEFAULT_RE_AUTHENTICATE_WAIT_TIME);
+ // for old client, don't wait for re-auth but unregister this proxy
completely.
+ if (getProxy().getVersion().isOlderThan(RE_AUTHENTICATION_START_VERSION)) {
Review Comment:
This block feels like it should be extracted into it's own method for
readability. It distracts from the primary method purpose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
