pivotal-eshu commented on code in PR #7596:
URL: https://github.com/apache/geode/pull/7596#discussion_r855677627
##########
geode-core/src/main/java/org/apache/geode/internal/cache/BucketRegion.java:
##########
@@ -604,17 +611,23 @@ public void handleWANEvent(EntryEventImpl event) {
if (!(this instanceof AbstractBucketRegionQueue)) {
if (getBucketAdvisor().isPrimary()) {
+ if (notPrimary && needToWaitForColocatedBucketsBecomePrimary()) {
Review Comment:
It is later accessed in needToWaitForColocatedBucketsBecomePrimary() with
synchronized on notPrimary. I see your point, the notPrimary may need to be
volatile. Was intend to avoid synchronization here to avoid regular cases
without colocated regions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
