mhansonp commented on code in PR #7608:
URL: https://github.com/apache/geode/pull/7608#discussion_r858093902
##########
geode-cq/src/distributedTest/java/org/apache/geode/internal/cache/tier/sockets/DurableClientTestBase.java:
##########
@@ -639,44 +627,44 @@ public void run2() throws CacheException {
*/
void checkHAQueueSize(VM server, final String durableClientId, final int
expectedNumber,
final int remaining) {
- server.invoke(new CacheSerializableRunnable(
- "Check ha queued size for durable client " + durableClientId) {
- @Override
- public void run2() throws CacheException {
+ server.invoke("Check ha queued size for durable client " + durableClientId,
+ new CacheSerializableRunnable() {
+ @Override
+ public void run2() throws CacheException {
- final CacheClientNotifier ccnInstance =
CacheClientNotifier.getInstance();
- final CacheClientProxy clientProxy =
ccnInstance.getClientProxy(durableClientId);
+ final CacheClientNotifier ccnInstance =
CacheClientNotifier.getInstance();
+ final CacheClientProxy clientProxy =
ccnInstance.getClientProxy(durableClientId);
- // Wait until we get the expected number of events or until 10 seconds
are up
- await()
- .until(() -> clientProxy.getQueueSizeStat() == expectedNumber
- || clientProxy.getQueueSizeStat() == remaining);
+ // Wait until we get the expected number of events or until 10
seconds are up
+ await()
+ .until(() -> clientProxy.getQueueSizeStat() == expectedNumber
+ || clientProxy.getQueueSizeStat() == remaining);
Review Comment:
Thanks for the clarification. I like that even though it sort of contradicts
my argument above about breaking errors out. I think this assert makes things
clear because it testing the same result, with fewer calls.
##########
geode-cq/src/distributedTest/java/org/apache/geode/internal/cache/tier/sockets/DurableClientTestBase.java:
##########
@@ -639,44 +627,44 @@ public void run2() throws CacheException {
*/
void checkHAQueueSize(VM server, final String durableClientId, final int
expectedNumber,
final int remaining) {
- server.invoke(new CacheSerializableRunnable(
- "Check ha queued size for durable client " + durableClientId) {
- @Override
- public void run2() throws CacheException {
+ server.invoke("Check ha queued size for durable client " + durableClientId,
+ new CacheSerializableRunnable() {
+ @Override
+ public void run2() throws CacheException {
- final CacheClientNotifier ccnInstance =
CacheClientNotifier.getInstance();
- final CacheClientProxy clientProxy =
ccnInstance.getClientProxy(durableClientId);
+ final CacheClientNotifier ccnInstance =
CacheClientNotifier.getInstance();
+ final CacheClientProxy clientProxy =
ccnInstance.getClientProxy(durableClientId);
- // Wait until we get the expected number of events or until 10 seconds
are up
- await()
- .until(() -> clientProxy.getQueueSizeStat() == expectedNumber
- || clientProxy.getQueueSizeStat() == remaining);
+ // Wait until we get the expected number of events or until 10
seconds are up
+ await()
+ .until(() -> clientProxy.getQueueSizeStat() == expectedNumber
+ || clientProxy.getQueueSizeStat() == remaining);
Review Comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
