dschneider-pivotal commented on PR #7621: URL: https://github.com/apache/geode/pull/7621#issuecomment-1110194657
@pivotal-jbarrett I also was concerned about the code smell that in the past we didn't just use limit instead of capacity. But given that someone went to the trouble of accessing a jdk internal feature to solve that issue, it seemed safer to not try to find the places that depended on capacity and limit being equal. We could do that and then might not beed the PooledByteBuffer instances. Another option would be to maintain a map in BufferPool that allows a slice being returned to the pool to have its original instance looked up. Then the ones that pay the extra overhead are when a slice was taken. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
