pivotal-jbarrett commented on code in PR #7424:
URL: https://github.com/apache/geode/pull/7424#discussion_r859191851
##########
geode-core/src/main/java/org/apache/geode/internal/lang/SystemPropertyHelper.java:
##########
@@ -113,6 +113,14 @@ public class SystemPropertyHelper {
*/
public static final String RE_AUTHENTICATE_WAIT_TIME =
"reauthenticate.wait.time";
+ /**
+ * Maximum number of concurrent executions in a server of wan-copy region
commands.
+ * Once the maximum number is reached, subsequent executions will be halted
until
+ * a thread for any of the ongoing executions is released.
+ */
+ public static final String WAN_COPY_REGION_MAX_CONCURRENT_THREADS =
+ "geode.wan.copy-region.max-threads";
Review Comment:
Here is the other PR #7517 currently under review. It uses the old
`GeodeGlossary.GEMFIRE_PREFIX` prefix with `Class.CONSTANT` suffix. It also
directly access System Properties directly via `Integer.getInteger`. This PR
uses a hardcoded `geode` prefix and utilizes
`SystemProperty.getProductIntegerProperty`. I haven't had time to investigate a
better and consistent approach to naming and access. Just raising it again here
some maybe someone will and post a proposal to dev@geode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
